Re: [PATCH v2 09/11] block: Expose queue nr_zones in sysfs

Damien Le Moal
2018-10-12T00:41:59Z

On 2018/10/11 23:42, Ewan D. Milne wrote:=0A=
> So in v2 you moved the #ifdef CONFIG_BLK_DEV_ZONED=0A=
> so that nr_zones is always present? It was previously=0A=
> changed to keep the request_queue size smaller.=0A=
> =0A=
> Would make more sense to make the nr_zones sysfs=0A=
> code here conditional on CONFIG_BLK_DEV_ZONED?=0A=
> =0A=
=0A=
Yes, I guess it would. #ifdef in c code is normally not welcome, so I was a=
=0A=
little heavy handed with this v2 change to avoid adding any to blk-sysfs.c =
:)=0A=
=0A=
I will rework this and send a v3.=0A=
=0A=
Thanks for the review.=0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=