Re: [PATCH 16/17] mtd_blkdevs: convert to blk-mq

Jens Axboe
2018-10-11T21:14:07Z

On 10/11/18 3:03 PM, Richard Weinberger wrote:
> Jens,
>
> On Thu, Oct 11, 2018 at 7:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Straight forward conversion, using an internal list to enable the
>> driver to pull requests at will.
>>
>> Dynamically allocate the tag set to avoid having to pull in the
>> block headers for blktrans.h, since various mtd drivers use
>> block conflicting names for defines and functions.
>
> This explodes on my test system. :-/

I think I see it, that was pretty stupid... Can you try with this one
on top as well?

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index c26d692781af..e8f8fddce063 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -187,8 +187,8 @@ static void mtd_blktrans_work(struct mtd_blktrans_dev *dev)
mutex_unlock(&dev->lock);

if (!blk_update_request(req, res, blk_rq_cur_bytes(req))) {
- req = NULL;
__blk_mq_end_request(req, res);
+ req = NULL;
}

background_done = 0;

--
Jens Axboe