Re: [PATCH 03/17] ps3disk: convert to blk-mq

Jens Axboe
2018-10-15T19:30:48Z

On 10/15/18 1:24 PM, Geoff Levand wrote:
> Hi Jens,
>
> On 10/15/2018 11:38 AM, Jens Axboe wrote:
>> Weird, it looks like we're waiting for something to complete, and then
>> we have a few others waiting for queue new IO.
>>
>> Can you try and move the blk_mq_end_request() inside the priv->lock
>> section and see if that helps?
>
> With the change below to your V2 I can't get it to have an
> error. I did mkfs.ext4, some big file downloads, and ran
> 'fsck.ext3 -c' for a while.

OK good, that's better than having to make the bigger change I
just sent out.

> Thanks for working late on it.

Thanks for testing! I'll add your tested-by.

--
Jens Axboe