Re: [PATCH 03/17] ps3disk: convert to blk-mq

Jens Axboe
2018-10-15T18:38:21Z

On 10/15/18 12:23 PM, Geoff Levand wrote:
> Hi Jens,
>
> On 10/15/2018 09:27 AM, Jens Axboe wrote:> Can you try and change the queue depth to 1 instead of 2? It's set in> the tag_set, as ->queue_depth.
>
> With this change:
>
> - set->queue_depth = 2;
> + set->queue_depth = 1;
>
> Something is still wrong. It can sometimes boot, sometimes udevd hangs
> up on /sbin/blkid. If it boots I can sometimes mount a ps3disk
> partition, but then cat or echo to a file will hang. Other times the
> mount command will hang. I saw this error appear in the system log:

Weird, it looks like we're waiting for something to complete, and then
we have a few others waiting for queue new IO.

Can you try and move the blk_mq_end_request() inside the priv->lock
section and see if that helps?

--
Jens Axboe