From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jianchao Wang <jianchao.w.wang@oracle.com>,
axboe@kernel.dk, martin.petersen@oracle.com,
tom.leiming@gmail.com, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] block: fix the DISCARD request merge
Date: Mon, 22 Oct 2018 11:08:49 +0200 [thread overview]
Message-ID: <20181022090849.GA19053@lst.de> (raw)
In-Reply-To: <20181022090601.GA21171@ming.t460p>
On Mon, Oct 22, 2018 at 05:06:02PM +0800, Ming Lei wrote:
>
> The above may be changed to 'if (blk_try_merge(req) == ELEVATOR_DISCARD_MERGE)'
> or sort of in future, which may has document benefit at least, since
> ELEVATOR_DISCARD_MERGE means multi-segment discard merge.
I like that idea, and we should do it for the respin
next prev parent reply other threads:[~2018-10-22 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 14:29 [PATCH V2] block: fix the DISCARD request merge Jianchao Wang
2018-10-22 9:00 ` Christoph Hellwig
2018-10-22 10:13 ` jianchao.wang
2018-10-22 9:06 ` Ming Lei
2018-10-22 9:08 ` Christoph Hellwig [this message]
2018-10-22 10:14 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022090849.GA19053@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox