Re: [PATCH 1/2] loop/006: Add test for setting partscan flag

[Jan Kara <jack@suse.cz>]

On Mon 22-10-18 15:52:55, Omar Sandoval wrote:
> On Thu, Oct 18, 2018 at 12:31:46PM +0200, Jan Kara wrote:
> > Add test for setting partscan flag.
> > 
> > Signed-off-by: Jan Kara <jack@suse.cz>
> 
> Sorry I didn't notice this earlier, but loop/001 already does a
> partition rescan (via losetup -P). Does that cover this test case?

Yes I know. But the partition rescanning on device creation has been
handled properly while partition rescanning as a result of LOOP_SET_STATUS
was buggy. That's why I've added this test.

> > +int main(int argc, char **argv)
> > +{
> > +	int ret;
> > +	int fd;
> > +	struct loop_info64 info;
> > +
> > +	if (argc != 2)
> > +		usage(argv[0]);
> > +
> > +	fd = open(argv[1], O_RDONLY);
> > +	if (fd == -1) {
> > +		perror("open");
> > +		return EXIT_FAILURE;
> > +	}
> > +
> > +	memset(&info, 0, sizeof(info));
> > +	info.lo_flags = LO_FLAGS_PARTSCAN;
> > +	memcpy(info.lo_file_name, "part", 5);
> 
> What's the significance of this file name?

Probably none, I guess I can just delete it. I think I've just copy-pasted
it from some other test excercising LOOP_SET_STATUS...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR