From: Omar Sandoval <osandov@osandov.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH 1/2] loop/006: Add test for setting partscan flag
Date: Tue, 23 Oct 2018 11:57:50 -0700 [thread overview]
Message-ID: <20181023185750.GF10074@vader> (raw)
In-Reply-To: <20181023100512.GA4695@quack2.suse.cz>
On Tue, Oct 23, 2018 at 12:05:12PM +0200, Jan Kara wrote:
> On Mon 22-10-18 15:52:55, Omar Sandoval wrote:
> > On Thu, Oct 18, 2018 at 12:31:46PM +0200, Jan Kara wrote:
> > > Add test for setting partscan flag.
> > >
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> >
> > Sorry I didn't notice this earlier, but loop/001 already does a
> > partition rescan (via losetup -P). Does that cover this test case?
>
> Yes I know. But the partition rescanning on device creation has been
> handled properly while partition rescanning as a result of LOOP_SET_STATUS
> was buggy. That's why I've added this test.
At least here, losetup -P does a LOOP_SET_STATUS:
$ sudo strace -e ioctl losetup -f --show -P test.img
ioctl(3, LOOP_CTL_GET_FREE) = 0
ioctl(4, LOOP_SET_FD, 3) = 0
ioctl(4, LOOP_SET_STATUS64, {lo_offset=0, lo_number=0, lo_flags=LO_FLAGS_PARTSCAN, lo_file_name="/home/osandov/test.img", ...}) = 0
/dev/loop0
+++ exited with 0 +++
next prev parent reply other threads:[~2018-10-24 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 10:31 [PATCH 0/2] blktests: New loop tests Jan Kara
2018-10-18 10:31 ` [PATCH 1/2] loop/006: Add test for setting partscan flag Jan Kara
2018-10-18 14:18 ` Johannes Thumshirn
2018-10-22 22:52 ` Omar Sandoval
2018-10-23 10:05 ` Jan Kara
2018-10-23 18:57 ` Omar Sandoval [this message]
2018-10-24 13:14 ` Jan Kara
2018-10-18 10:31 ` [PATCH 2/2] loop/007: Add test for oops during backing file verification Jan Kara
2018-10-18 14:19 ` Johannes Thumshirn
2018-10-22 22:55 ` Omar Sandoval
2018-10-25 21:18 ` [PATCH 0/2] blktests: New loop tests Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023185750.GF10074@vader \
--to=osandov@osandov.com \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).