Re: [PATCH 2/3] block: cleanup __blkdev_issue_discard()

Christoph Hellwig
2018-10-26T07:45:15Z

On Fri, Oct 26, 2018 at 02:24:34PM +0800, Ming Lei wrote:
> Cleanup __blkdev_issue_discard().

It would help to explain what you clean up..

> + unsigned int req_sects = min(nr_sects, (UINT_MAX >> 9) & ~bs_mask);

This creates an overly long line.