From: Christoph Hellwig <hch@lst.de>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: axboe@kernel.dk, martin.petersen@oracle.com,
tom.leiming@gmail.com, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] block: fix the DISCARD request merge
Date: Sun, 28 Oct 2018 16:48:35 +0100 [thread overview]
Message-ID: <20181028154835.GA3061@lst.de> (raw)
In-Reply-To: <1540641134-21485-1-git-send-email-jianchao.w.wang@oracle.com>
On Sat, Oct 27, 2018 at 07:52:14PM +0800, Jianchao Wang wrote:
> +enum elv_merge blk_try_req_merge(struct request *req, struct request *next)
> +{
> + if (blk_discard_mergable(req))
> + return ELEVATOR_DISCARD_MERGE;
> + else if (blk_rq_pos(req) + blk_rq_sectors(req) == blk_rq_pos(next))
> + return ELEVATOR_BACK_MERGE;
> +
> + return ELEVATOR_NO_MERGE;
The empty line here look a little odd, but if that is the only thing
I can nitpick about it must be great, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-10-28 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 11:52 [PATCH V5] block: fix the DISCARD request merge Jianchao Wang
2018-10-28 15:48 ` Christoph Hellwig [this message]
2018-10-29 9:44 ` Ming Lei
2018-10-29 15:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028154835.GA3061@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox