From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Rui Salvaterra <rsalvaterra@gmail.com>,
stable@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>,
Xiao Ni <xni@redhat.com>,
Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Subject: Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size
Date: Sun, 28 Oct 2018 16:49:47 +0100 [thread overview]
Message-ID: <20181028154947.GB3061@lst.de> (raw)
In-Reply-To: <20181028005130.GA26731@ming.t460p>
On Sun, Oct 28, 2018 at 08:51:31AM +0800, Ming Lei wrote:
> On Fri, Oct 26, 2018 at 09:44:15AM +0200, Christoph Hellwig wrote:
> > > if (req_sects > UINT_MAX >> 9)
> > > - req_sects = UINT_MAX >> 9;
> > > + req_sects = (UINT_MAX >> 9) & ~bs_mask;
> >
> > Given that we have this same thing duplicated in write zeroes
> > what about a documented helper?
>
> IMO, using UINT_MAX & bs_mask is better because it is self-explanatory
> in the context.
I don't think it is in any way. I understand it because I know the
code, but there is nothing that documents why we do that.
next prev parent reply other threads:[~2018-10-28 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 6:24 [PATCH 0/3] block: make sure discard/writesame bio is aligned with logical block size Ming Lei
2018-10-26 6:24 ` [PATCH 1/3] block: make sure discard " Ming Lei
2018-10-26 7:44 ` Christoph Hellwig
2018-10-28 0:51 ` Ming Lei
2018-10-28 15:49 ` Christoph Hellwig [this message]
2018-10-29 2:42 ` Ming Lei
2018-10-26 6:24 ` [PATCH 2/3] block: cleanup __blkdev_issue_discard() Ming Lei
2018-10-26 7:45 ` Christoph Hellwig
2018-10-26 6:24 ` [PATCH 3/3] block: make sure writesame bio is aligned with logical block size Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028154947.GB3061@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mariusz.dabrowski@intel.com \
--cc=ming.lei@redhat.com \
--cc=rsalvaterra@gmail.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox