From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 29/29] block: get rid of blk_queued_rq()
Date: Mon, 29 Oct 2018 10:34:44 -0600 [thread overview]
Message-ID: <20181029163444.9940-30-axboe@kernel.dk> (raw)
In-Reply-To: <20181029163444.9940-1-axboe@kernel.dk>
No point in hiding what this does, just open code it in the
one spot where we are still using it.
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
block/blk-mq.c | 2 +-
include/linux/blkdev.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index d43c9232c77c..21e4147c4810 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -692,7 +692,7 @@ void blk_mq_requeue_request(struct request *rq, bool kick_requeue_list)
/* this request will be re-inserted to io scheduler queue */
blk_mq_sched_requeue_request(rq);
- BUG_ON(blk_queued_rq(rq));
+ BUG_ON(!list_empty(&rq->queuelist));
blk_mq_add_to_requeue_list(rq, true, kick_requeue_list);
}
EXPORT_SYMBOL(blk_mq_requeue_request);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index e0c661a95c39..c675e2b5af62 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -673,8 +673,6 @@ static inline bool blk_account_rq(struct request *rq)
#define blk_rq_cpu_valid(rq) ((rq)->cpu != -1)
#define blk_bidi_rq(rq) ((rq)->next_rq != NULL)
-/* rq->queuelist of dequeued request must be list_empty() */
-#define blk_queued_rq(rq) (!list_empty(&(rq)->queuelist))
#define list_entry_rq(ptr) list_entry((ptr), struct request, queuelist)
--
2.17.1
prev parent reply other threads:[~2018-10-29 16:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 16:34 [PATCHSET v2 0/29] blk-mq driver conversions and legacy path removal Jens Axboe
2018-10-29 16:34 ` [PATCH 01/29] sunvdc: convert to blk-mq Jens Axboe
2018-10-29 16:34 ` [PATCH 02/29] ms_block: " Jens Axboe
2018-10-29 16:34 ` [PATCH 03/29] mspro_block: " Jens Axboe
2018-10-29 16:34 ` [PATCH 04/29] ide: " Jens Axboe
2018-10-29 16:34 ` [PATCH 05/29] blk-mq: remove the request_list usage Jens Axboe
2018-10-29 16:34 ` [PATCH 06/29] blk-mq: remove legacy check in queue blk_freeze_queue() Jens Axboe
2018-10-29 16:34 ` [PATCH 07/29] blk-mq: provide mq_ops->busy() hook Jens Axboe
2018-10-29 16:56 ` Hannes Reinecke
2018-10-29 16:34 ` [PATCH 08/29] scsi: " Jens Axboe
2018-10-29 16:57 ` Hannes Reinecke
2018-10-29 16:34 ` [PATCH 09/29] scsi: kill off the legacy IO path Jens Axboe
2018-10-29 16:34 ` [PATCH 10/29] block: remove q->lld_busy_fn() Jens Axboe
2018-10-29 16:58 ` Hannes Reinecke
2018-10-29 16:34 ` [PATCH 11/29] dasd: remove dead code Jens Axboe
2018-10-29 16:34 ` [PATCH 12/29] bsg: pass in desired timeout handler Jens Axboe
2018-10-29 16:34 ` [PATCH 13/29] bsg: provide bsg_remove_queue() helper Jens Axboe
2018-10-29 16:59 ` Hannes Reinecke
2018-10-29 16:34 ` [PATCH 14/29] bsg: convert to use blk-mq Jens Axboe
2018-10-29 16:59 ` Hannes Reinecke
2018-10-29 16:34 ` [PATCH 15/29] block: remove blk_complete_request() Jens Axboe
2018-10-29 16:34 ` [PATCH 16/29] blk-wbt: kill check for legacy queue type Jens Axboe
2018-10-29 16:34 ` [PATCH 17/29] blk-cgroup: remove legacy queue bypassing Jens Axboe
2018-10-29 16:34 ` [PATCH 18/29] block: remove legacy rq tagging Jens Axboe
2018-10-29 16:34 ` [PATCH 19/29] block: remove non mq parts from the flush code Jens Axboe
2018-10-29 16:34 ` [PATCH 20/29] block: remove legacy IO schedulers Jens Axboe
2018-10-29 16:34 ` [PATCH 21/29] block: remove dead elevator code Jens Axboe
2018-10-29 16:34 ` [PATCH 22/29] block: remove __blk_put_request() Jens Axboe
2018-10-29 16:34 ` [PATCH 23/29] block: kill legacy parts of timeout handling Jens Axboe
2018-10-29 16:34 ` [PATCH 24/29] bsg: move bsg-lib parts outside of request queue Jens Axboe
2018-10-29 17:00 ` Hannes Reinecke
2018-10-29 16:34 ` [PATCH 25/29] block: remove request_list code Jens Axboe
2018-10-29 16:34 ` [PATCH 26/29] block: kill request slab cache Jens Axboe
2018-10-29 16:34 ` [PATCH 27/29] block: remove req_no_special_merge() from merging code Jens Axboe
2018-10-29 16:34 ` [PATCH 28/29] blk-merge: kill dead queue lock held check Jens Axboe
2018-10-29 16:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029163444.9940-30-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).