From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B556C43441 for ; Fri, 16 Nov 2018 08:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4D732145D for ; Fri, 16 Nov 2018 08:32:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YNKCllmx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4D732145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbeKPSn4 (ORCPT ); Fri, 16 Nov 2018 13:43:56 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59138 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727575AbeKPSn4 (ORCPT ); Fri, 16 Nov 2018 13:43:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fgdbpXwPDDXpBT3JYANFLU8gho/dMo0BJK2hug40bP4=; b=YNKCllmxehiwAEydx9QL03BVx XFVmQ4vdJojoYfiulNOpckL6hgGd5u4+YAtlwEqKZaQIo6o5J8vTIUGNPOTYDeCo0O5jAK4uXhEcU jNJ0rNWomspP7KuEKdUrP4rvGFVxW0g0aKzArlAL5cvVG7geWPueec+Glq9hmfQwMCtlzB4kVN4eI HlHHAUl7K0jlOZvQ/uySRfqQBPRFORvPd367HVQ0gVIwXDrIwM2NO4KxBv8ImIZdTgnv+8uAVuxO1 VQIVPcrx7IvDnhNRvTclrh62giVHxPGwWoMc5Bx5UaljvV6YPc/Xq+E0mudkuy+laoQDgYhNdQEbO jfnvbN2Bw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNZYH-0002PZ-C8; Fri, 16 Nov 2018 08:32:33 +0000 Date: Fri, 16 Nov 2018 00:32:33 -0800 From: Christoph Hellwig To: Dave Chinner Cc: "Darrick J. Wong" , Ming Lei , Jens Axboe , linux-xfs@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] block: fix 32 bit overflow in __blkdev_issue_discard() Message-ID: <20181116083232.GA9023@infradead.org> References: <20181113214337.20581-1-david@fromorbit.com> <10a8dd78-7c00-8593-9f4e-b20eb1161b92@kernel.dk> <20181115010651.GD32603@ming.t460p> <20181115012201.GX19305@dastard> <20181115031035.GE32603@ming.t460p> <20181115221337.GY19305@dastard> <20181115222419.GV4235@magnolia> <20181116040457.GA19305@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116040457.GA19305@dastard> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Nov 16, 2018 at 03:04:57PM +1100, Dave Chinner wrote: > They don't run on my test machines because they require a modular > kernel and I run a monolithic kernel specified externally by the > qemu command line on all my test VMs. > > generic/349 [not run] scsi_debug module not found > generic/350 [not run] scsi_debug module not found > generic/351 [not run] scsi_debug module not found Same here, btw. Any test that requires modules is a rather bad idea.