Re: [PATCH 5/6] ide: don't acquire queue_lock in ide_complete_pm_rq

Omar Sandoval
2018-11-16T08:42:26Z

On Fri, Nov 16, 2018 at 09:40:04AM +0100, Christoph Hellwig wrote:
> On Fri, Nov 16, 2018 at 12:37:32AM -0800, Omar Sandoval wrote:
> > On Fri, Nov 16, 2018 at 09:10:05AM +0100, Christoph Hellwig wrote:
> > > blk_mq_stop_hw_queues doesn't need any locking, and the ide
> > > dev_flags field isn't protected by it either.
> >
> > Is it a bug that dev_flags is no longer protected by queue_lock after
> > the mq conversion?
>
> Most if not all users weren't under queue_lock before. As far as I can
> tell it generally is set in the probe path, and without any obvious
> locking.

Good enough for me, you can add

Reviewed-by: Omar Sandoval <osandov@fb.com>