From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CADCC43441 for ; Mon, 19 Nov 2018 07:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9C00206BB for ; Mon, 19 Nov 2018 07:59:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ClFHMCPI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9C00206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbeKSSVz (ORCPT ); Mon, 19 Nov 2018 13:21:55 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:58820 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726348AbeKSSVz (ORCPT ); Mon, 19 Nov 2018 13:21:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h+xl77EADp5eRvK4q/BuajExpon/gmbN0vyHDWLrCxM=; b=ClFHMCPIoXJHT+fOxTjymWmvk zWpAGc+AHooJtTzdWD/J9C75dxoIigT2vN5OD+wQurE6JqP3v4dLtB8lo+w/ChotDwFZz0Y727hC5 cd0Q8U74+NIaSNx6OQhTkjTgX47uSDVgjeiQ74ckPBKjDWb27ldcKNafIqUr7ohPvEdiZ/ZLSQbUm VD375HuSeqsAQsy1E48bCaHB1BL7BlTRQoeNLpSLeKLSJ+KlQsTiPN0hbE/Lt9n/GvxcsJXrUNhqV ONCDt7vN3c9gXnZusrw60OLsdbhvOQR+b1a3lJ0DeXmIbnEb9kWWaessHIKpCCpiZdG8EGJkuquni 6LjcYUkTg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gOeSW-0003I1-RF; Mon, 19 Nov 2018 07:59:04 +0000 Date: Sun, 18 Nov 2018 23:59:04 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 3/7] nvme-fc: remove unused poll implementation Message-ID: <20181119075904.GC9622@infradead.org> References: <20181117214354.822-1-axboe@kernel.dk> <20181117214354.822-4-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181117214354.822-4-axboe@kernel.dk> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Nov 17, 2018 at 02:43:50PM -0700, Jens Axboe wrote: > This relies on the fc taget ops setting ->poll_queue, which > nobody does. Otherwise it just checks if something has > completed, which isn't very useful. Please also remove the unused ->poll_queue method. Otherwise looks fine: Reviewed-by: Christoph Hellwig