From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/5] aio: add support for file based polled IO
Date: Mon, 19 Nov 2018 00:12:07 -0800 [thread overview]
Message-ID: <20181119081207.GK9622@infradead.org> (raw)
In-Reply-To: <20181117235317.7366-6-axboe@kernel.dk>
On Sat, Nov 17, 2018 at 04:53:17PM -0700, Jens Axboe wrote:
> Needs further work, but this should work fine on normal setups
> with a file system on a pollable block device.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
> fs/aio.c | 2 ++
> fs/direct-io.c | 4 +++-
> fs/iomap.c | 7 +++++--
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 500da3ffc376..e02085fe10d7 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1310,6 +1310,8 @@ static struct block_device *aio_bdev_host(struct kiocb *req)
>
> if (S_ISBLK(inode->i_mode))
> return I_BDEV(inode);
> + else if (inode->i_sb && inode->i_sb->s_bdev)
> + return inode->i_sb->s_bdev;
This is broken for multi-device filesystems, e.g. XFS with the RT
device, or btrfs. See my patch in reply to your last one for an idea
how to solve this.
prev parent reply other threads:[~2018-11-19 8:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 23:53 [PATCHSET 0/5] Support for polled aio Jens Axboe
2018-11-17 23:53 ` [PATCH 1/5] aio: use assigned completion handler Jens Axboe
2018-11-19 8:06 ` Christoph Hellwig
2018-11-17 23:53 ` [PATCH 2/5] aio: fix failure to put the file pointer Jens Axboe
2018-11-19 8:07 ` Christoph Hellwig
2018-11-19 15:39 ` Jens Axboe
2018-11-17 23:53 ` [PATCH 3/5] aio: add iocb->ki_blk_qc field Jens Axboe
2018-11-19 1:59 ` Dave Chinner
2018-11-19 2:59 ` Jens Axboe
2018-11-17 23:53 ` [PATCH 4/5] aio: support for IO polling Jens Axboe
2018-11-19 8:11 ` Christoph Hellwig
2018-11-19 13:32 ` Christoph Hellwig
2018-11-19 16:07 ` Jens Axboe
2018-11-17 23:53 ` [PATCH 5/5] aio: add support for file based polled IO Jens Axboe
2018-11-19 1:57 ` Dave Chinner
2018-11-19 2:58 ` Jens Axboe
2018-11-19 8:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119081207.GK9622@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).