From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <keith.busch@intel.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Martin Petersen <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCHv3 3/3] blk-mq: Simplify request completion state
Date: Mon, 19 Nov 2018 00:58:59 -0800 [thread overview]
Message-ID: <20181119085859.GC29626@infradead.org> (raw)
In-Reply-To: <20181115175820.13391-4-keith.busch@intel.com>
On Thu, Nov 15, 2018 at 10:58:20AM -0700, Keith Busch wrote:
> There are no more users relying on blk-mq request states to prevent
> double completions, so replace the relatively expensive cmpxchg operation
> with WRITE_ONCE.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-11-19 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 17:58 [PATCHv3 0/3] scsi timeout handling updates Keith Busch
2018-11-15 17:58 ` [PATCHv3 1/3] blk-mq: Return true if request was completed Keith Busch
2018-11-19 8:31 ` Christoph Hellwig
2018-11-15 17:58 ` [PATCHv3 2/3] scsi: Do not rely on blk-mq for double completions Keith Busch
2018-11-16 9:53 ` Hannes Reinecke
2018-11-16 14:46 ` Bart Van Assche
2018-11-19 8:58 ` Christoph Hellwig
2018-11-19 15:17 ` Jens Axboe
2018-11-19 15:19 ` Keith Busch
2018-11-21 13:12 ` Christoph Hellwig
2018-11-26 15:32 ` Jens Axboe
2018-11-26 15:31 ` Keith Busch
2018-11-15 17:58 ` [PATCHv3 3/3] blk-mq: Simplify request completion state Keith Busch
2018-11-19 8:58 ` Christoph Hellwig [this message]
2018-11-15 19:53 ` [PATCHv3 0/3] scsi timeout handling updates Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119085859.GC29626@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).