From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67FDEC43441 for ; Mon, 19 Nov 2018 08:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 316EC2087A for ; Mon, 19 Nov 2018 08:59:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dFftumTl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 316EC2087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727226AbeKSTV7 (ORCPT ); Mon, 19 Nov 2018 14:21:59 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37700 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbeKSTV6 (ORCPT ); Mon, 19 Nov 2018 14:21:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uliJ5N+1NHr3PweuuLZmcCPmojVEGynuzZGPW34MyGM=; b=dFftumTlRgqk6ZlGBorlrf5cc EW5dT1+CO9Ue10mgbJTGj//tNaelvntIqHa6qTWTz584wPxMPA+T18gO1RvnCWdK3wXIHVJgJN/3O QZxbiiVVfpl2D+TT+9rquoCMcDTsGXIzBtAhaTOAO1GL6NB0Qz42FcoMTKda/7Qbr13Hb14AGiZj3 QGQFYgXe+TKOEg/Q6Jd62nraNUhZyRBF/C5Vyv96QZAj44qqcIEeqXTHCR/HQ3bhSMF9igaP8QzUM lmmiX25QrS3GITmCVlSyQDO7kZcZsCY/JosCaGSXcN2WRsGsRTLJc0vs7qj0+xzSfnKxSlwV+HiLL nr90oNOww==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gOfOV-0000Hb-Dj; Mon, 19 Nov 2018 08:58:59 +0000 Date: Mon, 19 Nov 2018 00:58:59 -0800 From: Christoph Hellwig To: Keith Busch Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , Martin Petersen , Bart Van Assche Subject: Re: [PATCHv3 3/3] blk-mq: Simplify request completion state Message-ID: <20181119085859.GC29626@infradead.org> References: <20181115175820.13391-1-keith.busch@intel.com> <20181115175820.13391-4-keith.busch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115175820.13391-4-keith.busch@intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 15, 2018 at 10:58:20AM -0700, Keith Busch wrote: > There are no more users relying on blk-mq request states to prevent > double completions, so replace the relatively expensive cmpxchg operation > with WRITE_ONCE. > > Signed-off-by: Keith Busch Looks fine, Reviewed-by: Christoph Hellwig