Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver

Sagi Grimberg
2018-11-27T07:48:09Z

>>> This looks odd.  It's not really the timeout handlers job to
>>> call nvme_end_request here.
>>
>> Well.. if we are not yet LIVE, we will not trigger error
>> recovery, which means nothing will complete this command so
>> something needs to do it...
>>
>> I think that we need it for rdma too..
>
>
> yes we do. and we've patches in our pipe.
>
> I'm thinking on a wider change in the error/recovery flows but might
> send it "as is" meanwhile.

I have it too in the pipe. Do you want to send it out or should I?