From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F17CC43441 for ; Mon, 26 Nov 2018 22:44:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 526CD208E4 for ; Mon, 26 Nov 2018 22:44:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="Z0bQFfql" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 526CD208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=osandov.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727311AbeK0Jka (ORCPT ); Tue, 27 Nov 2018 04:40:30 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:37975 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbeK0JkX (ORCPT ); Tue, 27 Nov 2018 04:40:23 -0500 Received: by mail-pg1-f194.google.com with SMTP id g189so6860096pgc.5 for ; Mon, 26 Nov 2018 14:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cA9eOqjetgKdwTc0IyYrmBxIamtijscygN3GSsAT39o=; b=Z0bQFfqlNiGrkj90Vl6WWbS+aa0UGMgFkN5W5rWNB0z7ULOP4pQv4acxcfxe2Yu8qB 4W3Sww2RJW17EOid7sccXAKeBNDhBUgM6gKCJHhAcTuUhkIm1q7U9zB5wGs/6e9+B1sB jO3SNgel20symJK9mP+LJ7Y3kpOfRghqXkkhCU9QL4oO3tB7ZQTRPZP5kfan5gMDGUqK ByXzD3ty1oNCWb336xuJZx0OHpUV+9jUUPIC92388B5wMuCva9C/hlBOKo7B4LDv/ZX0 xuB6whVjbQKLUy9bAF/R6Nq8fEBlkfdluRV1yKs7Bl7Nw+VkHmjSzJ3j7ID3cQBCTnDZ VFeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cA9eOqjetgKdwTc0IyYrmBxIamtijscygN3GSsAT39o=; b=eCPAERerOIJeJ05Hb9Nfbi2KXLUifIJucuGIJ0zyx7d8+ybNp84rB4QtX0A3Uf4dDs e3RSGyK1Wsn/iKCFYK29dBFTWm53O1I876uuXNX/GeWoeGNSPtOrHovZYMsP1CwJa/Zy GrIGgy3xE/y6iCpLbo+6NJkI5GgogNRFnj5kgIULIuRrLhkkQJtSMld/TKeF/Hry2ewA 5fj3PcXflo9BnpWkH+4mNTT/GRDecOUF00MPb0TMGM7XeXSeL2xMJgS1VY3XGFdKv+5K xs4tv5v6KWaG4fJ4UTTV1JKqs6htXmo2fhyNvIkNljNFiX8o8MqLQ+NC5fx3dCQXZ/iX pl+Q== X-Gm-Message-State: AA+aEWbtjtyUvxCR0Q60+M61DyBoOM48MqEcpMmo6iIOMZsxoKbpwwdH SHlotZcUFzd1M2cUHPfaxLekdw== X-Google-Smtp-Source: AFSGD/VY8xs+PEaRm5mqycYa0Hlc3dDL4yii3H+Z1byxLEHStBdMF628b3PHLUEXvo+3AFN58Vvpvw== X-Received: by 2002:a63:2054:: with SMTP id r20mr26725129pgm.328.1543272282188; Mon, 26 Nov 2018 14:44:42 -0800 (PST) Received: from vader ([2601:602:8b00:55d3:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id l63-v6sm1769066pfb.75.2018.11.26.14.44.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 14:44:41 -0800 (PST) Date: Mon, 26 Nov 2018 14:44:39 -0800 From: Omar Sandoval To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V12 17/20] block: always define BIO_MAX_PAGES as 256 Message-ID: <20181126224439.GN30411@vader> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-18-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126021720.19471-18-ming.lei@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Nov 26, 2018 at 10:17:17AM +0800, Ming Lei wrote: > Now multi-page bvec can cover CONFIG_THP_SWAP, so we don't need to > increase BIO_MAX_PAGES for it. > > CONFIG_THP_SWAP needs to split one THP into normal pages and adds > them all to one bio. With multipage-bvec, it just takes one bvec to > hold them all. > > Reviewed-by: Christoph Hellwig Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- > include/linux/bio.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 5505f74aef8b..7be48c55b14a 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -34,15 +34,7 @@ > #define BIO_BUG_ON > #endif > > -#ifdef CONFIG_THP_SWAP > -#if HPAGE_PMD_NR > 256 > -#define BIO_MAX_PAGES HPAGE_PMD_NR > -#else > #define BIO_MAX_PAGES 256 > -#endif > -#else > -#define BIO_MAX_PAGES 256 > -#endif > > #define bio_prio(bio) (bio)->bi_ioprio > #define bio_set_prio(bio, prio) ((bio)->bi_ioprio = prio) > -- > 2.9.5 >