From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7678AC43441 for ; Thu, 29 Nov 2018 20:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 450BE20673 for ; Thu, 29 Nov 2018 20:40:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 450BE20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726348AbeK3HrQ (ORCPT ); Fri, 30 Nov 2018 02:47:16 -0500 Received: from mga06.intel.com ([134.134.136.31]:35282 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726190AbeK3HrQ (ORCPT ); Fri, 30 Nov 2018 02:47:16 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2018 12:40:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,295,1539673200"; d="scan'208";a="113661005" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga002.jf.intel.com with ESMTP; 29 Nov 2018 12:40:35 -0800 Date: Thu, 29 Nov 2018 13:37:41 -0700 From: Keith Busch To: Christoph Hellwig Cc: Jens Axboe , Sagi Grimberg , Max Gurtovoy , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: Re: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Message-ID: <20181129203740.GF9377@localhost.localdomain> References: <20181129191310.9795-1-hch@lst.de> <20181129191310.9795-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181129191310.9795-7-hch@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 29, 2018 at 08:13:03PM +0100, Christoph Hellwig wrote: > Pass the opcode for the delete SQ/CQ command as an argument instead of > the somewhat confusing pass loop. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Keith Busch