From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>,
hch@lst.de, sagi@grimberg.me, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Kernel crashes after 529262d56dbe "block: remove ->poll_fn"
Date: Wed, 5 Dec 2018 14:47:27 +0100 [thread overview]
Message-ID: <20181205134727.GA26794@lst.de> (raw)
In-Reply-To: <a6efd5b2-3190-54e7-ad4c-06f9ac441641@kernel.dk>
On Wed, Dec 05, 2018 at 06:39:26AM -0700, Jens Axboe wrote:
> > What device is this?
>
> This might also help...
Yes, it should. I had missed that we turned on QUEUE_FLAG_POLL
by default, which is rather odd. The even weirder things is that
git-blame claims it was me who enabled it :)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 0b3874bdbc6a..81f1b105946b 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -606,8 +606,7 @@ struct request_queue {
> (1 << QUEUE_FLAG_ADD_RANDOM))
>
> #define QUEUE_FLAG_MQ_DEFAULT ((1 << QUEUE_FLAG_IO_STAT) | \
> - (1 << QUEUE_FLAG_SAME_COMP) | \
> - (1 << QUEUE_FLAG_POLL))
> + (1 << QUEUE_FLAG_SAME_COMP))
>
> void blk_queue_flag_set(unsigned int flag, struct request_queue *q);
> void blk_queue_flag_clear(unsigned int flag, struct request_queue *q);
>
> --
> Jens Axboe
---end quoted text---
next prev parent reply other threads:[~2018-12-05 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 12:19 Kernel crashes after 529262d56dbe "block: remove ->poll_fn" Kirill Tkhai
2018-12-05 12:45 ` Jens Axboe
2018-12-05 13:05 ` Kirill Tkhai
2018-12-05 13:20 ` Jens Axboe
2018-12-05 13:39 ` Jens Axboe
2018-12-05 13:47 ` Christoph Hellwig [this message]
2018-12-05 13:48 ` Jens Axboe
2018-12-05 14:08 ` Kirill Tkhai
2018-12-05 14:05 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205134727.GA26794@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ktkhai@virtuozzo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox