From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Todd Aiken <taiken@mvtech.ca>,
Keith Busch <keith.busch@intel.com>,
Laurence Oberman <loberman@redhat.com>,
stable@vger.kernel.org
Subject: [PATCH] block: Restore tape support
Date: Sun, 9 Dec 2018 19:08:14 -0800 [thread overview]
Message-ID: <20181210030814.13235-1-bvanassche@acm.org> (raw)
According to what I found in
https://bugzilla.kernel.org/show_bug.cgi?id=201935 patch "block: Clear
kernel memory before copying to user" broke tape access. Hence revert
that patch.
Reported-by: Todd Aiken <taiken@mvtech.ca>
Fixes: f3587d76da05 ("block: Clear kernel memory before copying to user") # v4.20-rc2
Cc: Todd Aiken <taiken@mvtech.ca>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Laurence Oberman <loberman@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/bio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index 06760543ec81..90c32cd3e0c7 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1262,7 +1262,6 @@ struct bio *bio_copy_user_iov(struct request_queue *q,
if (ret)
goto cleanup;
} else {
- zero_fill_bio(bio);
iov_iter_advance(iter, bio->bi_iter.bi_size);
}
--
2.19.2
next reply other threads:[~2018-12-10 3:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 3:08 Bart Van Assche [this message]
2018-12-10 11:17 ` [PATCH] block: Restore tape support Christoph Hellwig
2018-12-10 15:11 ` Laurence Oberman
2018-12-10 15:32 ` Keith Busch
2018-12-10 15:36 ` Jens Axboe
2018-12-10 16:17 ` Laurence Oberman
2018-12-10 20:06 ` Laurence Oberman
2018-12-10 20:26 ` Keith Busch
2018-12-10 20:38 ` Todd Aiken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210030814.13235-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=stable@vger.kernel.org \
--cc=taiken@mvtech.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).