From: Keith Busch <keith.busch@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Todd Aiken <taiken@mvtech.ca>,
Laurence Oberman <loberman@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: Restore tape support
Date: Mon, 10 Dec 2018 08:32:30 -0700 [thread overview]
Message-ID: <20181210153230.GB25206@localhost.localdomain> (raw)
In-Reply-To: <20181210030814.13235-1-bvanassche@acm.org>
On Sun, Dec 09, 2018 at 07:08:14PM -0800, Bart Van Assche wrote:
> According to what I found in
> https://bugzilla.kernel.org/show_bug.cgi?id=201935 patch "block: Clear
> kernel memory before copying to user" broke tape access. Hence revert
> that patch.
Instead of reverting back to the leaking arbitrary kernel memory, why
not just make a fix on top of it? This should do it:
---
diff --git a/block/bio.c b/block/bio.c
index c4ef8aa46452..55a5386fd431 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1262,7 +1262,8 @@ struct bio *bio_copy_user_iov(struct request_queue *q,
if (ret)
goto cleanup;
} else {
- zero_fill_bio(bio);
+ if (bmd->is_our_pages)
+ zero_fill_bio(bio);
iov_iter_advance(iter, bio->bi_iter.bi_size);
}
--
next prev parent reply other threads:[~2018-12-10 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 3:08 [PATCH] block: Restore tape support Bart Van Assche
2018-12-10 11:17 ` Christoph Hellwig
2018-12-10 15:11 ` Laurence Oberman
2018-12-10 15:32 ` Keith Busch [this message]
2018-12-10 15:36 ` Jens Axboe
2018-12-10 16:17 ` Laurence Oberman
2018-12-10 20:06 ` Laurence Oberman
2018-12-10 20:26 ` Keith Busch
2018-12-10 20:38 ` Todd Aiken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210153230.GB25206@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=stable@vger.kernel.org \
--cc=taiken@mvtech.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox