From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 5/5] nvme-rdma: support read/write queue separation
Date: Tue, 11 Dec 2018 14:42:20 +0100 [thread overview]
Message-ID: <20181211134220.GE20614@lst.de> (raw)
In-Reply-To: <20181211104936.25333-6-sagi@grimberg.me>
This probably wants a little explanation..
> struct nvme_rdma_ctrl *ctrl = set->driver_data;
> + struct blk_mq_queue_map *map;
> + int offset = 0;
> +
> + if (ctrl->ctrl.opts->nr_write_queues) {
> + /* separate read/write queues */
> + map = &set->map[HCTX_TYPE_DEFAULT];
> + map->queue_offset = offset;
> + map->nr_queues = ctrl->ctrl.opts->nr_write_queues;
> + blk_mq_rdma_map_queues(map, ctrl->device->dev, 0);
> + offset += map->nr_queues;
> +
> + map = &set->map[HCTX_TYPE_READ];
> + map->nr_queues = ctrl->ctrl.opts->nr_io_queues;
> + map->queue_offset = offset;
> + blk_mq_rdma_map_queues(map, ctrl->device->dev, offset);
> + offset += map->nr_queues;
>
> + } else {
> + /* mixed read/write queues */
> + map = &set->map[HCTX_TYPE_DEFAULT];
> + map->queue_offset = 0;
> + map->nr_queues = ctrl->ctrl.opts->nr_io_queues;
> + blk_mq_rdma_map_queues(map, ctrl->device->dev, 0);
> +
> + map = &set->map[HCTX_TYPE_READ];
> + map->queue_offset = 0;
> + map->nr_queues = ctrl->ctrl.opts->nr_io_queues;
> + blk_mq_rdma_map_queues(map, ctrl->device->dev, 0);
> + }
Same comment and suggested style as for the TCP one.
next prev parent reply other threads:[~2018-12-11 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 10:49 [PATCH 0/5] implement nvmf read/write queue maps Sagi Grimberg
2018-12-11 10:49 ` [PATCH 1/5] blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues Sagi Grimberg
2018-12-11 13:34 ` Christoph Hellwig
2018-12-11 10:49 ` [PATCH 2/5] nvme-fabrics: add missing nvmf_ctrl_options documentation Sagi Grimberg
2018-12-11 13:35 ` Christoph Hellwig
2018-12-11 10:49 ` [PATCH 3/5] nvme-fabrics: allow user to set nr_write_queues for separate queue maps Sagi Grimberg
2018-12-11 13:35 ` Christoph Hellwig
2018-12-11 10:49 ` [PATCH 4/5] nvme-tcp: support separate queue maps for read and write Sagi Grimberg
2018-12-11 13:41 ` Christoph Hellwig
2018-12-11 23:11 ` Sagi Grimberg
2018-12-11 10:49 ` [PATCH 5/5] nvme-rdma: support read/write queue separation Sagi Grimberg
2018-12-11 13:42 ` Christoph Hellwig [this message]
2018-12-11 10:49 ` [PATCH nvme-cli 6/5] fabrics: pass in nr_write_queues Sagi Grimberg
2018-12-11 19:30 ` Keith Busch
2018-12-11 23:34 ` Sagi Grimberg
2018-12-11 13:28 ` [PATCH 0/5] implement nvmf read/write queue maps Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211134220.GE20614@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).