From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE09AC5CFFE for ; Tue, 11 Dec 2018 19:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78BF72087F for ; Tue, 11 Dec 2018 19:18:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lightnvm-io.20150623.gappssmtp.com header.i=@lightnvm-io.20150623.gappssmtp.com header.b="nJAhIR2e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78BF72087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lightnvm.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbeLKTRF (ORCPT ); Tue, 11 Dec 2018 14:17:05 -0500 Received: from mail-lf1-f46.google.com ([209.85.167.46]:46157 "EHLO mail-lf1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbeLKTRF (ORCPT ); Tue, 11 Dec 2018 14:17:05 -0500 Received: by mail-lf1-f46.google.com with SMTP id f23so11596563lfc.13 for ; Tue, 11 Dec 2018 11:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TmJnvhRDq+XrZ6hTWK6vWKJ3pmK1jX6DMSH7DISlQQQ=; b=nJAhIR2ekuo/pDaTHJnKPQ41v1LVN+1Fcipk9yKag7i2HBjDKqwsneXLBAMZ3HNMPc 0Wkq9/9bEkmEC+p1pzJuJGlcYyYwF84qISAXEeWII4dWm5n1OJez4pAdATmBop3tWXVJ 6GZaX+6ttrlW4BHCCA2YB0uX2M8Q6h3hf0nf39JhRND46Ch6FNNpdWVvZ9K+fbpfhKoF fqqV0xtsuqM6e4x8YqmtzFmClyuMGuAI8Th1oa9zJjVbjn4Jyjsqwt04Co2O/8vNztyO LYSxoLhIiMo5gu42luuOjA6qQPcUc9CyjLgUbPDcMusOIVo58gDkBz5FsXliRdivX/rt gydQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TmJnvhRDq+XrZ6hTWK6vWKJ3pmK1jX6DMSH7DISlQQQ=; b=Lt8ShcHtbss165O8tYJyo8kOvCfRRFkP3ZTq07+rkXv5d6Sng501ZprVk+oIp0XGPR 2CbrmbdkpdOmnXGPl4Y/K6OywOZNK5Qb8gbl3e/OvaFO3ghDE1AKg6f3ycjsH1kBXzPP 5S0iqnkNIvhyLoh5PD8NHr5mLIuVq/nhuVlzdoQkzY2zSChMNTDt1x15umq+eXeaaNPF /oS++o3ze5UqXYFAdcEs3Ue6dds+HFZmPWlZ1mafbYz2kCp2+yjDaB25v/StPDAePck4 tRiqqwcSzp0qGb+X4/UGFcnWWKr1b5JcosZSwe30UTP7Of+q9sskiZ3IPKGLNsnGSXuv 8mhQ== X-Gm-Message-State: AA+aEWYRGGsL7Kha8TOteBO+k0b6QkWsoK6Rm3Un0UeLZWnhI4iQaL0i 1NHvNvORejROcPLS8qKJMlZ/Hw== X-Google-Smtp-Source: AFSGD/V4z7A7w5bxMIBz3HhhLRXWA1lKxef+gsGt7P3OX7m9jF39S9EttCvgJw316YCkghb51g3WOA== X-Received: by 2002:a19:a149:: with SMTP id k70mr10051471lfe.5.1544555822844; Tue, 11 Dec 2018 11:17:02 -0800 (PST) Received: from skyninja.webspeed.dk (95-166-82-66-cable.dk.customer.tdc.net. [95.166.82.66]) by smtp.gmail.com with ESMTPSA id v64sm2764583lfa.48.2018.12.11.11.17.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Dec 2018 11:17:01 -0800 (PST) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Holmberg , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 03/21] lightnvm: pblk: fix chunk close trace event check Date: Tue, 11 Dec 2018 20:16:09 +0100 Message-Id: <20181211191627.15542-4-mb@lightnvm.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181211191627.15542-1-mb@lightnvm.io> References: <20181211191627.15542-1-mb@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: Hans Holmberg The check for chunk closes suffers from an off-by-one issue, leading to chunk close events not being traced. Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states") Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index 6944aac43b01..6581c35f51ee 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd) if (caddr == 0) trace_pblk_chunk_state(pblk_disk_name(pblk), ppa, NVM_CHK_ST_OPEN); - else if (caddr == chunk->cnlb) + else if (caddr == (chunk->cnlb - 1)) trace_pblk_chunk_state(pblk_disk_name(pblk), ppa, NVM_CHK_ST_CLOSED); } -- 2.17.1