From: Christoph Hellwig <hch@infradead.org>
To: Parshuram Raju Thombare <pthombar@cadence.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"vinholikatti@gmail.com" <vinholikatti@gmail.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"tj@kernel.org" <tj@kernel.org>, "jbacik@fb.com" <jbacik@fb.com>,
"michaelcallahan@fb.com" <michaelcallahan@fb.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"osandov@fb.com" <osandov@fb.com>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"shli@fb.com" <shli@fb.com>,
"dennisszhou@gmail.com" <dennisszhou@gmail.com>,
Alan Douglas <adouglas@cadence.com>,
Janek Kotas <jank@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>
Subject: Re: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD
Date: Tue, 11 Dec 2018 23:40:17 -0800 [thread overview]
Message-ID: <20181212074017.GA19904@infradead.org> (raw)
In-Reply-To: <CO2PR07MB24692595C49430F56CE5DAC2C1A60@CO2PR07MB2469.namprd07.prod.outlook.com>
On Tue, Dec 11, 2018 at 06:22:27PM +0000, Parshuram Raju Thombare wrote:
> One reason of using device mapper here is to use existing tools like
> 'dmsetup', otherwise some user space application is needed and may be
> some changes in block layer to pass the crypto information (crypto
> algorithm, key etc) till ufs driver.
Yes, so what? We also don't use dmsetup to set up TCG OPAL based
encryption either.
> Another reason is supporting multiple UFS devices. I think, as you said
> UFS crypto support can be added by some change in ufs driver and block
> layer glue. But to support multiple UFS crypto devices having different
> crypto configs (crypto algorithms, key size etc), crypto context need to
> be saved per crypto device which may need some changes in block layer code.
I don't think we need device mapper for that. We can hav the crypto
state hanging off the ufs host, or request_queue if we decide to
implement it generic in the block layer.
prev parent reply other threads:[~2018-12-12 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:49 [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD Parshuram Thombare
2018-12-11 14:06 ` Christoph Hellwig
2018-12-11 18:22 ` Parshuram Raju Thombare
2018-12-12 7:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212074017.GA19904@infradead.org \
--to=hch@infradead.org \
--cc=adouglas@cadence.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dennisszhou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=jbacik@fb.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+samsung@kernel.org \
--cc=michaelcallahan@fb.com \
--cc=ming.lei@redhat.com \
--cc=nicolas.ferre@microchip.com \
--cc=osandov@fb.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
--cc=shli@fb.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).