From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF36C65BAF for ; Wed, 12 Dec 2018 15:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD22D20879 for ; Wed, 12 Dec 2018 15:18:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD22D20879 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbeLLPSw (ORCPT ); Wed, 12 Dec 2018 10:18:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53942 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbeLLPSw (ORCPT ); Wed, 12 Dec 2018 10:18:52 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1F147F6C7; Wed, 12 Dec 2018 15:18:51 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9022560C46; Wed, 12 Dec 2018 15:18:45 +0000 (UTC) Date: Wed, 12 Dec 2018 10:18:44 -0500 From: Mike Snitzer To: Eric Sandeen Cc: Jens Axboe , sandeen@redhat.com, fstests@vger.kernel.org, "linux-block@vger.kernel.org" , device-mapper development , Christoph Hellwig Subject: Re: xfstests generic/347 was never correct [was: Re: dm: fix inflight IO check] Message-ID: <20181212151844.GA24433@redhat.com> References: <4fec4b01-35f9-8008-22ec-2ac8af58b854@kernel.dk> <20181211003204.GA14673@redhat.com> <20181212023424.GA21119@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 12 Dec 2018 15:18:51 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 11 2018 at 9:58pm -0500, Eric Sandeen wrote: > On 12/11/18 8:34 PM, Mike Snitzer wrote: > > On Mon, Dec 10 2018 at 7:32pm -0500, > > Mike Snitzer wrote: > > > > SO generic/347 needs to account for 2 things: > > 1) issue $XFS_IO_PROG IO in the background with other process(es) > > 2) in parallel, in main generic/347 shell, run _dmthin_grow but the > > "thin" device must be suspended with dmsetup suspend --noflush > > > > Eric Sandeen: can you or someone else xfstests inclined use this info to > > fix generic/347 please? > > It's not at all clear to me what is wrong with the test. "Do a bunch of IO > including a sync, completely filling the backing store, then grow the backing store" > is surely a real-world scenario that dm-thinp might encounter, no? Things > do recover, subsequent writes succeed, and when all is said and done the filesystem > is checked and it's still consistent. That sounds like some version of success to me. > > Even if it's emulating a dumb user/administrator, that doesn't seem invalid. > > What is wrong here? I told you in elaborate detail. Your willingness to leave generic/347 as is makes little sense; but that is your call. I'll just move on...