From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Jeff Moyer <jmoyer@redhat.com>, Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 4/4] blk-mq-debugfs: export hctx->type
Date: Sun, 16 Dec 2018 10:25:17 +0800 [thread overview]
Message-ID: <20181216022517.26650-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20181216022517.26650-1-ming.lei@redhat.com>
Now we only export hctx->type via sysfs, and there isn't such info
in hctx entry under debugfs. We often use debugfs only to diagnose
queue mapping issue, so add the support in debugfs.
Queue mapping becomes a bit more complicated after multiple queue
mapping is supported, we may write blktest to verify if queue mapping
is valid based on blk-mq-debug.
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq-debugfs.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index a32bb79d6c95..219e29d49a49 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -636,6 +636,14 @@ static int hctx_dispatch_busy_show(void *data, struct seq_file *m)
return 0;
}
+static int hctx_type_show(void *data, struct seq_file *m)
+{
+ struct blk_mq_hw_ctx *hctx = data;
+
+ seq_printf(m, "%u\n", hctx->type);
+ return 0;
+}
+
static void *ctx_rq_list_start(struct seq_file *m, loff_t *pos)
__acquires(&ctx->lock)
{
@@ -798,6 +806,7 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_hctx_attrs[] = {
{"run", 0600, hctx_run_show, hctx_run_write},
{"active", 0400, hctx_active_show},
{"dispatch_busy", 0400, hctx_dispatch_busy_show},
+ {"type", 0400, hctx_type_show},
{},
};
--
2.9.5
next prev parent reply other threads:[~2018-12-16 2:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 2:25 [PATCH 0/4] blk-mq: queue mapping fix & improvement Ming Lei
2018-12-16 2:25 ` [PATCH 1/4] nvme-pci: correct mapping for poll queue(s) Ming Lei
2018-12-16 16:11 ` Christoph Hellwig
2018-12-17 1:00 ` Ming Lei
2018-12-17 7:06 ` Christoph Hellwig
2018-12-17 7:22 ` Ming Lei
2018-12-16 2:25 ` [PATCH 2/4] blk-mq: fix allocation for queue mapping table Ming Lei
2018-12-16 16:15 ` Christoph Hellwig
2018-12-16 2:25 ` [PATCH 3/4] blk-mq: deal with shared queue mapping reliably Ming Lei
2018-12-16 16:16 ` Christoph Hellwig
2018-12-16 18:39 ` Mike Snitzer
2018-12-16 19:12 ` Jens Axboe
2018-12-17 1:04 ` Ming Lei
2018-12-17 7:44 ` Christoph Hellwig
2018-12-17 8:38 ` Ming Lei
2018-12-17 1:27 ` Ming Lei
2018-12-16 2:25 ` Ming Lei [this message]
2018-12-16 16:17 ` [PATCH 4/4] blk-mq-debugfs: export hctx->type Christoph Hellwig
2018-12-16 19:12 ` Jens Axboe
2018-12-17 1:06 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216022517.26650-5-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).