Re: [PATCH 4/4] blk-mq-debugfs: export hctx->type

[Christoph Hellwig <hch@lst.de>]

On Sun, Dec 16, 2018 at 10:25:17AM +0800, Ming Lei wrote:
> Now we only export hctx->type via sysfs, and there isn't such info
> in hctx entry under debugfs. We often use debugfs only to diagnose
> queue mapping issue, so add the support in debugfs.
> 
> Queue mapping becomes a bit more complicated after multiple queue
> mapping is supported, we may write blktest to verify if queue mapping
> is valid based on blk-mq-debug.

I'll let Jens decide if we really want to double export information
like this (or maybe even move it to debugfs only?)

> +static int hctx_type_show(void *data, struct seq_file *m)
> +{
> +	struct blk_mq_hw_ctx *hctx = data;
> +
> +	seq_printf(m, "%u\n", hctx->type);
> +	return 0;

But if we export it we should probably export it as a text, just
like we do for sysfs now.