From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B58DBC43387 for ; Sun, 16 Dec 2018 16:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D7F9206BA for ; Sun, 16 Dec 2018 16:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730449AbeLPQlb (ORCPT ); Sun, 16 Dec 2018 11:41:31 -0500 Received: from verein.lst.de ([213.95.11.211]:57931 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729910AbeLPQlb (ORCPT ); Sun, 16 Dec 2018 11:41:31 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id AA0E168DD3; Sun, 16 Dec 2018 17:41:30 +0100 (CET) Date: Sun, 16 Dec 2018 17:41:30 +0100 From: Christoph Hellwig To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, hch@lst.de, jmoyer@redhat.com, clm@fb.com Subject: Re: [PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT Message-ID: <20181216164130.GD13234@lst.de> References: <20181213175645.22181-1-axboe@kernel.dk> <20181213175645.22181-25-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213175645.22181-25-axboe@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > + if (iov_iter_is_bvec(iter)) > + ret = bio_iov_bvec_add_pages(&bio, iter); > + else > + ret = bio_iov_iter_get_pages(&bio, iter); Shouldn't this actually be done inside bio_iov_iter_get_pages?