From: Omar Sandoval <osandov@osandov.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: osandov@fb.com, linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] blktests: make block/026 run in constant time
Date: Tue, 18 Dec 2018 15:12:03 -0800 [thread overview]
Message-ID: <20181218231203.GB12683@vader> (raw)
In-Reply-To: <20181212154552.10422-1-josef@toxicpanda.com>
On Wed, Dec 12, 2018 at 10:45:52AM -0500, Josef Bacik wrote:
> The original test just did 4g of IO and figured out how long it took to
> determine if io.latency was working properly. However this can run
> really long on slow disks, so instead run for a constant time and check
> the bandwidth of the two cgroups to determine if io.latency is doing the
> right thing.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Thanks, this is better. This still fails on my emulated NVMe device on
QEMU with "Too much of a performance drop for the protected workload".
The total I/O goes down from about 2.4 GB to 1.8 GB, so about 75%. It
works reliably on virtio-blk and virtio-scsi. Is the device hopeless, or
should the configuration/thresholds be tweaked?
prev parent reply other threads:[~2018-12-18 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 15:45 [PATCH] blktests: make block/026 run in constant time Josef Bacik
2018-12-18 23:12 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218231203.GB12683@vader \
--to=osandov@osandov.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox