Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH] bsg: deprecate BIDI support in bsg
Date: Wed, 19 Dec 2018 15:39:34 +0100	[thread overview]
Message-ID: <20181219143934.3910-1-hch@lst.de> (raw)

Besides the OSD command set that never got traction, the only SCSI
command using bidirectional buffers is XDWRITEREAD in the 10 and 32
byte variants, which is extremely esoteric.  It probably doesn't make
sense to keep the support code around just for that, so start
deprecating the support.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/bsg.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/block/bsg.c b/block/bsg.c
index 9a442c23a715..60b41bf79e16 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -177,6 +177,10 @@ bsg_map_hdr(struct request_queue *q, struct sg_io_v4 *hdr, fmode_t mode)
 			goto out;
 		}
 
+		pr_warn_once(
+			"BIDI support in bsg has been deprecated and might be removed. "
+			"Please report your use case to linux-scsi@vger.kernel.org\n");
+
 		next_rq = blk_get_request(q, REQ_OP_SCSI_IN, 0);
 		if (IS_ERR(next_rq)) {
 			ret = PTR_ERR(next_rq);
-- 
2.19.2


             reply	other threads:[~2018-12-19 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 14:39 Christoph Hellwig [this message]
2018-12-19 23:07 ` [PATCH] bsg: deprecate BIDI support in bsg Bart Van Assche
2018-12-20  7:12   ` Christoph Hellwig
2018-12-19 23:23 ` Jens Axboe
2018-12-20  7:12   ` Christoph Hellwig
2018-12-20 17:09     ` Jens Axboe
2018-12-20 18:19       ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219143934.3910-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox