From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, ming.lei@redhat.com
Subject: Re: [PATCHSET v2] Fix kyber hang
Date: Thu, 20 Dec 2018 11:15:10 -0800 [thread overview]
Message-ID: <20181220191510.GD11852@vader> (raw)
In-Reply-To: <20181220160149.4042-1-axboe@kernel.dk>
On Thu, Dec 20, 2018 at 09:01:47AM -0700, Jens Axboe wrote:
> Since the wrong kyber patch was included in the first one, here's a
> v2 with just that one line corrected.
>
> First one adds the necessary sbitmap helpers for users to be able to
> do add_wait_queue() and list_del(wait_entry) type operations, and
> still work with the optimized wakeup checking.
>
> Second one converts kyber to use it, fixing a hang with domain tokens.
Lame, I should've caught this on the original patch. For the series:
Reviewed-by: Omar Sandoval <osandov@fb.com>
next prev parent reply other threads:[~2018-12-20 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 16:01 [PATCHSET v2] Fix kyber hang Jens Axboe
2018-12-20 16:01 ` [PATCH 1/2] sbitmap: add helpers for add/del wait queue handling Jens Axboe
2018-12-20 16:01 ` [PATCH 2/2] kyber: use sbitmap add_wait_queue/list_del wait helpers Jens Axboe
2018-12-20 16:56 ` [PATCHSET v2] Fix kyber hang Ming Lei
2018-12-20 17:37 ` Jens Axboe
2018-12-20 19:15 ` Omar Sandoval [this message]
2018-12-20 19:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220191510.GD11852@vader \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).