From: Omar Sandoval <osandov@osandov.com>
To: Dennis Zhou <dennis@kernel.org>
Cc: Omar Sandoval <osandov@fb.com>, Ming Lei <ming.lei@redhat.com>,
kernel-team@fb.com, linux-block@vger.kernel.org
Subject: Re: [PATCH blktests v2 0/2] Add scsi-stress-remove to blktests
Date: Thu, 20 Dec 2018 15:56:17 -0800 [thread overview]
Message-ID: <20181220235617.GF11852@vader> (raw)
In-Reply-To: <20181220181826.55481-1-dennis@kernel.org>
On Thu, Dec 20, 2018 at 12:18:24PM -0600, Dennis Zhou wrote:
> Hi,
>
> v2:
> There was a minor typo in 0001 pointed out by Omar which I fixed here.
> 0002 was refactored to use common/scsi_debug. I also rebased onto the
> top of osandov#josef changing the test from block/022 -> block/027.
>
> From v1:
> Ming Lei's scsi-stress-remove test found a bug in blkg destruction [1]
> where bios being created when the request_queue was being cleaned up
> threw a NPE in blkg association. The fix is currently being discussed in
> [2]. To make this test more accessible, I've ported it to blktests with
> Ming Lei's copyright. I've tested this in my qemu instance and verified
> we do not see the NPE on a fixed kernel.
>
> Ming, please let me know if you have any objections.
>
> [1] https://lore.kernel.org/linux-block/CACVXFVO_QXipD3cmPvpLyBYSiEcWPN_ThQ=0pO9AwLqN-Lv93w@mail.gmail.com
> [2] https://lore.kernel.org/lkml/20181211230308.66276-1-dennis@kernel.org/
>
> This patchset is ontop of osandov#josef 98db2e11c97f.
>
> diffstats below:
>
> Dennis Zhou (2):
> blktests: split out cgroup2 controller and file check
> blktests: add Ming Lei's scsi-stress-remove
>
> common/cgroup | 18 +++++++----
> tests/block/027 | 73 +++++++++++++++++++++++++++++++++++++++++++++
> tests/block/027.out | 2 ++
> 3 files changed, 88 insertions(+), 5 deletions(-)
> create mode 100755 tests/block/027
> create mode 100644 tests/block/027.out
Thanks, Dennis, applied along with Josef's cgroup infrastructure patch.
prev parent reply other threads:[~2018-12-20 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 18:18 [PATCH blktests v2 0/2] Add scsi-stress-remove to blktests Dennis Zhou
2018-12-20 18:18 ` [PATCH blktests 1/2] blktests: split out cgroup2 controller and file check Dennis Zhou
2018-12-20 18:18 ` [PATCH blktests 2/2] blktests: add Ming Lei's scsi-stress-remove Dennis Zhou
2018-12-20 23:56 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220235617.GF11852@vader \
--to=osandov@osandov.com \
--cc=dennis@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox