From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, kernel-team@fb.com, osandov@fb.com
Subject: Re: [PATCH 1/3] blktests: add cgroup2 infrastructure
Date: Wed, 16 Jan 2019 17:40:39 -0800 [thread overview]
Message-ID: <20190117014039.GA25494@vader> (raw)
In-Reply-To: <1547570441.83374.112.camel@acm.org>
On Tue, Jan 15, 2019 at 08:40:41AM -0800, Bart Van Assche wrote:
> On Tue, 2019-01-01 at 19:13 -0800, Bart Van Assche wrote:
> > On 12/4/18 9:47 AM, Josef Bacik wrote:
> > > In order to test io.latency and other cgroup related things we need some
> > > supporting helpers to setup and tear down cgroup2. This adds support
> > > for checking that we can even configure cgroup2 things, set them up if
> > > need be, and then add the cleanup stuff to the main cleanup function so
> > > everything is always in a clean state.
> >
> > Is this the patch that went in as commit ae7daae7e35a ("blktests: add
> > cgroup2 infrastructure")? I think that commit introduced a regression.
> > With that patch applied the SRP tests fail as follows:
> >
> > # ./check -q srp/001
> > srp/001 (Create and remove LUNs)
> > runtime 4.067s ...
> > common/cgroup: line 25: CGROUP2_DIR: unbound variable
> >
> > Is this a known issue?
>
> Hi Josef,
>
> Had you noticed this e-mail?
>
> Thanks,
>
> Bart.
Hey, Bart, I just pushed a fix for this:
commit 8a274578e2895b9f0b66c09f3a8f63b5ff1293b2
Author: Omar Sandoval <osandov@fb.com>
Date: Wed Jan 16 17:34:19 2019 -0800
cgroup: test if CGROUP2_DIR is set with -v instead of -n
common/multipath-over-rdma does set -u, so -n "$CGROUP2_DIR" fails with
an unbound variable error. Instead, use -v to test if the variable was
set.
Signed-off-by: Omar Sandoval <osandov@fb.com>
diff --git a/common/cgroup b/common/cgroup
index 48e546f..554ebf7 100644
--- a/common/cgroup
+++ b/common/cgroup
@@ -22,7 +22,7 @@ _init_cgroup2()
_exit_cgroup2()
{
- if [[ -n $CGROUP2_DIR ]]; then
+ if [[ -v CGROUP2_DIR ]]; then
find "$CGROUP2_DIR" -type d -delete
unset CGROUP2_DIR
fi
next prev parent reply other threads:[~2019-01-17 1:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 17:47 [PATCH 0/3] io.latency test for blktests Josef Bacik
2018-12-04 17:47 ` [PATCH 1/3] blktests: add cgroup2 infrastructure Josef Bacik
2019-01-02 3:13 ` Bart Van Assche
2019-01-15 16:40 ` Bart Van Assche
2019-01-17 1:40 ` Omar Sandoval [this message]
2019-01-17 2:31 ` Bart Van Assche
2019-01-17 14:59 ` Josef Bacik
2018-12-04 17:47 ` [PATCH 2/3] blktests: add python scripts for parsing fio json output Josef Bacik
2018-12-04 22:28 ` Federico Motta
2018-12-05 9:20 ` Johannes Thumshirn
2018-12-04 17:47 ` [PATCH 3/3] blktests: block/025: an io.latency test Josef Bacik
2018-12-04 22:27 ` Federico Motta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117014039.GA25494@vader \
--to=osandov@osandov.com \
--cc=bvanassche@acm.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).