From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F05C282CA for ; Sun, 27 Jan 2019 21:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5943120880 for ; Sun, 27 Jan 2019 21:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727233AbfA0VJc (ORCPT ); Sun, 27 Jan 2019 16:09:32 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40530 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726920AbfA0VJc (ORCPT ); Sun, 27 Jan 2019 16:09:32 -0500 Received: from mx02.mta.xmission.com ([166.70.13.212]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gnrgJ-0001uf-7K; Sun, 27 Jan 2019 14:09:31 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gnrgI-0000bt-RG; Sun, 27 Jan 2019 14:09:31 -0700 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id 2F612217DC3; Sun, 27 Jan 2019 21:09:30 +0000 (UTC) Date: Sun, 27 Jan 2019 16:09:23 -0500 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190127210922.GN21149@hacktheplanet> References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <1548196307-12987-15-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548196307-12987-15-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gnrgI-0000bt-RG;;;mid=<20190127210922.GN21149@hacktheplanet>;;;hst=mx02.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me Subject: Re: [PATCH v3 14/16] block: sed-opal: pass steps via argument rather than via opal_dev X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx02.mta.xmission.com) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jan 22, 2019 at 11:31:45PM +0100, David Kozub wrote: > The steps argument is only read by the next function, so it can > be passed directly as an argument rather than via opal_dev. > > Normally, the steps is an array on the stack, so the pointer stops > being valid then the function that set opal_dev.steps returns. > If opal_dev.steps was not set to NULL before return it would become > a dangling pointer. When the steps are passed as argument this > becomes easier to see and more difficult to misuse. > > Signed-off-by: David Kozub Reviewed-by: Scott Bauer