From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552A5C282C4 for ; Mon, 4 Feb 2019 14:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23E472175B for ; Mon, 4 Feb 2019 14:45:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LtW8k+BE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729113AbfBDOoy (ORCPT ); Mon, 4 Feb 2019 09:44:54 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44014 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728767AbfBDOoy (ORCPT ); Mon, 4 Feb 2019 09:44:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nWUhkfmqJ6tHVPsUZ4Tt2P/jmCDl3R+8fZusfswXrJw=; b=LtW8k+BE5+zLekiZBj/nVAd5Y lokj826aRN0WPhX/IIul/eJYrX6HWYrTMgeVBD+MWXvOAUprYsjecTDikiy+RagNhiyMoizFXnEEU HE3n1w1hRDhUlJ0ZGIEUN3hQ0Q/Mg6710ndSViMeRsNFwGG9q5xQTG8Qzl6d1xHc99ZRjjlDzo50b TesA9zTg39zIrb58VGcH8srTpYv9yuELEU5phNYiD1Cz2WtuSwkcbVv5AB9fAsbcVv1EZrDu/vSFa 9HQVGv+5Vx3PAYce2NENeURIjSSJWaHLoTRq5rK7GOkwuw5cgjkAJv1/o5QyMusOadeU7LyFKr3xx bmtSPLb3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqfUJ-0008Ki-Gb; Mon, 04 Feb 2019 14:44:43 +0000 Date: Mon, 4 Feb 2019 06:44:43 -0800 From: Christoph Hellwig To: David Kozub Cc: Jens Axboe , Jonathan Derrick , Scott Bauer , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Subject: Re: [PATCH v4 04/16] block: sed-opal: close parameter list in cmd_finalize Message-ID: <20190204144443.GD31132@infradead.org> References: <1549054223-12220-1-git-send-email-zub@linux.fjfi.cvut.cz> <1549054223-12220-5-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549054223-12220-5-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Feb 01, 2019 at 09:50:11PM +0100, David Kozub wrote: > Every step ends by calling cmd_finalize (via finalize_and_send) > yet every step adds the token OPAL_ENDLIST on its own. Moving > this into cmd_finalize decreases code duplication. > > Co-authored-by: Jonas Rabenstein > Signed-off-by: David Kozub > Signed-off-by: Jonas Rabenstein > Reviewed-by: Scott Bauer Looks good, Reviewed-by: Christoph Hellwig