From: Jan Kara <jack@suse.cz>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk, jack@suse.cz
Subject: Re: [PATCH 1/2] loop: do not print warn message if partition scan is successful
Date: Thu, 21 Feb 2019 12:01:51 +0100 [thread overview]
Message-ID: <20190221110151.GE27474@quack2.suse.cz> (raw)
In-Reply-To: <1550722655-15102-2-git-send-email-dongli.zhang@oracle.com>
On Thu 21-02-19 12:17:34, Dongli Zhang wrote:
> Do not print warn message when the partition scan returns 0.
>
> Fixes: d57f3374ba48 ("loop: Move special partition reread handling in loop_clr_fd()")
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Yeah, thanks for the fix! Not sure how come I didn't see this in my
testing. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> drivers/block/loop.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index cf55389..7908673 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1115,8 +1115,9 @@ static int __loop_clr_fd(struct loop_device *lo, bool release)
> err = __blkdev_reread_part(bdev);
> else
> err = blkdev_reread_part(bdev);
> - pr_warn("%s: partition scan of loop%d failed (rc=%d)\n",
> - __func__, lo_number, err);
> + if (err)
> + pr_warn("%s: partition scan of loop%d failed (rc=%d)\n",
> + __func__, lo_number, err);
> /* Device is gone, no point in returning error */
> err = 0;
> }
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-02-21 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 4:17 [PATCH 0/2] loop: fix two issues introduced by prior commit Dongli Zhang
2019-02-21 4:17 ` [PATCH 1/2] loop: do not print warn message if partition scan is successful Dongli Zhang
2019-02-21 11:01 ` Jan Kara [this message]
2019-02-21 4:17 ` [PATCH 2/2] loop: set GENHD_FL_NO_PART_SCAN after blkdev_reread_part() Dongli Zhang
2019-02-21 11:30 ` Jan Kara
2019-02-21 15:25 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221110151.GE27474@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=dongli.zhang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox