From: Keith Busch <keith.busch@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: t@localhost.localdomain, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 1/5] blk-mq: Export reading mq request state
Date: Fri, 8 Mar 2019 14:14:32 -0700 [thread overview]
Message-ID: <20190308211431.GA5438@localhost.localdomain> (raw)
In-Reply-To: <1552078030.45180.88.camel@acm.org>
On Fri, Mar 08, 2019 at 12:47:10PM -0800, Bart Van Assche wrote:
> Thanks for the clarification. Are you aware of any mechanism in the NVMe spec
> that causes all outstanding requests to fail? With RDMA this is easy - all
> one has to do is to change the queue pair state into IB_QPS_ERR. See also
> ib_drain_qp() in the RDMA core.
Well, we can't always rely on hardware to provide completions. The
driver must be able to make forward progress if the device decides to
stop responding, or maybe it was disconnected, asserts, or experiences
an unsafe shutdown/powerloss.
> If no such mechanism has been defined in the NVMe spec: have you considered
> to cancel all outstanding requests instead of calling blk_mq_end_request() for
> all outstanding requests?
Isn't this cancelling requests? Is there an existing block interface
that accomplishes this?
next prev parent reply other threads:[~2019-03-08 21:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 17:40 [PATCH 1/5] blk-mq: Export reading mq request state Keith Busch
2019-03-08 17:40 ` [PATCH 2/5] blk-mq: Export iterating queue requests Keith Busch
2019-03-08 18:08 ` Bart Van Assche
2019-03-08 18:13 ` Keith Busch
2019-03-08 17:40 ` [PATCH 3/5] blk-mq: Iterate tagset over all requests Keith Busch
2019-03-08 17:40 ` [PATCH 4/5] nvme: Fail dead namespace's entered requests Keith Busch
2019-03-08 18:15 ` Bart Van Assche
2019-03-08 18:19 ` Keith Busch
2019-03-08 21:54 ` Bart Van Assche
2019-03-08 22:06 ` Keith Busch
2019-03-11 3:58 ` jianchao.wang
2019-03-11 15:42 ` Keith Busch
2019-03-08 17:40 ` [PATCH 5/5] nvme/pci: Remove queue IO flushing hack Keith Busch
2019-03-08 18:19 ` Bart Van Assche
2019-03-11 18:40 ` Christoph Hellwig
2019-03-11 19:37 ` Keith Busch
2019-03-27 8:31 ` Christoph Hellwig
2019-03-27 13:21 ` Keith Busch
2019-03-28 1:42 ` jianchao.wang
2019-03-28 3:33 ` Keith Busch
2019-03-08 18:07 ` [PATCH 1/5] blk-mq: Export reading mq request state Bart Van Assche
2019-03-08 18:15 ` Keith Busch
2019-03-08 18:42 ` Bart Van Assche
2019-03-08 19:19 ` Keith Busch
2019-03-08 20:47 ` Bart Van Assche
2019-03-08 21:14 ` Keith Busch [this message]
2019-03-08 21:25 ` Bart Van Assche
2019-03-08 21:31 ` Keith Busch
2019-03-08 20:21 ` Sagi Grimberg
2019-03-08 20:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308211431.GA5438@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=t@localhost.localdomain \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).