Re: [PATCH V2] blktests: add userspace IO test

Omar Sandoval
2019-03-11T20:55:09Z

On Tue, Mar 05, 2019 at 09:50:26AM +0800, Ming Lei wrote:
> Add one test to cover changes on block passthrough IO interface,
> such as blk_rq_map_user(), blk_rq_map_user_iov(), blk_rq_unmap_user()
> and blk_rq_map_kern().
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> tests/block/029 | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/block/029.out | 4 ++
> 2 files changed, 115 insertions(+)
> create mode 100755 tests/block/029
> create mode 100644 tests/block/029.out
>
> diff --git a/tests/block/029 b/tests/block/029
> new file mode 100755
> index 000000000000..c7c674464285
> --- /dev/null
> +++ b/tests/block/029
> @@ -0,0 +1,111 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> +# Copyright (c) 2019 Ming Lei <ming.lei@redhat.com>
> +#
> +# Test userspace IO on NVMe loop device

This is still missing a reference to the patch it's testing.

> +. tests/nvme/rc

Shouldn't this be in the nvme group?

> +DESCRIPTION="test userspace IO via nvme-cli read/write interface"
> +QUICK=1
> +
> +requires() {
> + _have_program nvme && _have_modules loop nvme-loop nvmet && \
> + _have_configfs
> +}
> +
> +__test_user_io()
> +{
> + local disk="$1"
> + local start=$2
> + local cnt=$3
> +
> + local bs=$(blockdev --getss $disk)

This still has a ton of missing quoting and shellcheck errors.

I fixed all of this and pushed to
https://github.com/osandov/blktests/tree/user-io. Let me know if this
looks fine and I'll push it to master.