From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
ris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, Omar Sandoval <osandov@fb.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH V2 02/10] block: avoid to break XEN by multi-page bvec
Date: Sun, 17 Mar 2019 18:01:04 +0800 [thread overview]
Message-ID: <20190317100112.8106-3-ming.lei@redhat.com> (raw)
In-Reply-To: <20190317100112.8106-1-ming.lei@redhat.com>
XEN has special page merge requirement, see xen_biovec_phys_mergeable().
We can't merge pages into one bvec simply for XEN.
So move XEN's specific check on page merge into __bio_try_merge_page(),
then abvoid to break XEN by multi-page bvec.
Cc: ris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Cc: Omar Sandoval <osandov@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/bio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/bio.c b/block/bio.c
index 71a78d9fb8b7..d8f48188937c 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -776,6 +776,8 @@ bool __bio_try_merge_page(struct bio *bio, struct page *page,
if (vec_end_addr + 1 != page_addr + off)
return false;
+ if (xen_domain() && !xen_biovec_phys_mergeable(bv, page))
+ return false;
if (same_page && (vec_end_addr & PAGE_MASK) != page_addr)
return false;
--
2.9.5
next prev parent reply other threads:[~2019-03-17 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 10:01 [PATCH V2 00/10] block: enable multi-page bvec for passthrough IO Ming Lei
2019-03-17 10:01 ` [PATCH V2 01/10] block: pass page to xen_biovec_phys_mergeable Ming Lei
2019-03-17 10:01 ` Ming Lei [this message]
2019-03-19 9:18 ` [PATCH V2 02/10] block: avoid to break XEN by multi-page bvec Juergen Gross
2019-03-17 10:01 ` [PATCH V2 03/10] block: don't merge adjacent bvecs to one segment in bio blk_queue_split Ming Lei
2019-03-17 10:01 ` [PATCH V2 04/10] block: cleanup bio_add_pc_page Ming Lei
2019-03-17 10:01 ` [PATCH V2 05/10] block: check if page is mergeable in one helper Ming Lei
2019-03-17 10:01 ` [PATCH V2 06/10] block: put the same page when adding it to bio Ming Lei
2019-03-17 10:01 ` [PATCH V2 07/10] block: enable multi-page bvec for passthrough IO Ming Lei
2019-03-17 10:01 ` [PATCH V2 08/10] block: remove argument of 'request_queue' from __blk_bvec_map_sg Ming Lei
2019-03-17 10:01 ` [PATCH V2 09/10] block: reuse __blk_bvec_map_sg() for mapping page sized bvec Ming Lei
2019-03-17 10:01 ` [PATCH V2 10/10] block: don't check if adjacent bvecs in one bio can be mergeable Ming Lei
2019-03-27 15:44 ` [PATCH V2 00/10] block: enable multi-page bvec for passthrough IO Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317100112.8106-3-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=hch@lst.de \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).