From: Ming Lei <ming.lei@redhat.com>
To: "zhengbin (A)" <zhengbin13@huawei.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, houtao1@huawei.com,
yanaijie@huawei.com, jianchao.w.wang@oracle.com
Subject: Re: [PATCH] blk-mq: fix a hung issue when set device state to blocked and restore running
Date: Wed, 20 Mar 2019 17:29:53 +0800 [thread overview]
Message-ID: <20190320092951.GA9051@ming.t460p> (raw)
In-Reply-To: <c0821276-2127-e6d8-97b0-b96628d11ba7@huawei.com>
On Wed, Mar 20, 2019 at 04:52:40PM +0800, zhengbin (A) wrote:
> Thanks for your quick reply, I will study BLK_STS_DEV_RESOURCE in detail
>
> > BLK_STS_DEV_RESOURCE means that the driver will rerun hw queue, so
> > maybe you need to investigate why it is returned from scsi driver first.
> because we set the device state to blocked,
> scsi_queue_rq-->prep_to_mq(return BLK_STS_RESOURCE)
> -->out_put_budget transfer BLK_STS_RESOURCE to BLK_STS_DEV_RESOURCE
> In this situtation, the request does not send to the driver.
Then the queue will be run when the scsi_device becomes un-blocked,
see scsi_internal_device_unblock_nowait().
Thanks,
Ming
next prev parent reply other threads:[~2019-03-20 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 8:02 [PATCH] blk-mq: fix a hung issue when set device state to blocked and restore running zhengbin
2019-03-20 8:11 ` Ming Lei
2019-03-20 8:52 ` zhengbin (A)
2019-03-20 9:29 ` Ming Lei [this message]
2019-03-20 8:15 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320092951.GA9051@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).