public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH blktests] add checking nvmet module in nvme 002,003,004,015,018 test
@ 2019-03-13  7:13 Xiao Liang
  2019-03-13 17:47 ` Chaitanya Kulkarni
  2019-03-21 22:07 ` Omar Sandoval
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Liang @ 2019-03-13  7:13 UTC (permalink / raw)
  To: linux-block, osandov; +Cc: xiliang

Signed-off-by: Xiao Liang <xiliang@redhat.com>
---
 tests/nvme/002 | 2 +-
 tests/nvme/003 | 2 +-
 tests/nvme/004 | 2 +-
 tests/nvme/015 | 2 +-
 tests/nvme/018 | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/nvme/002 b/tests/nvme/002
index 0132ac0..106a5a8 100755
--- a/tests/nvme/002
+++ b/tests/nvme/002
@@ -10,7 +10,7 @@
 DESCRIPTION="create many subsystems and test discovery"
 
 requires() {
-	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
+	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
 }
 
 test() {
diff --git a/tests/nvme/003 b/tests/nvme/003
index f304071..c6b3d40 100755
--- a/tests/nvme/003
+++ b/tests/nvme/003
@@ -11,7 +11,7 @@ DESCRIPTION="test if we're sending keep-alives to a discovery controller"
 QUICK=1
 
 requires() {
-	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
+	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
 }
 
 test() {
diff --git a/tests/nvme/004 b/tests/nvme/004
index 346f309..0506fa2 100755
--- a/tests/nvme/004
+++ b/tests/nvme/004
@@ -12,7 +12,7 @@ DESCRIPTION="test nvme and nvmet UUID NS descriptors"
 QUICK=1
 
 requires() {
-	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
+	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
 }
 
 test() {
diff --git a/tests/nvme/015 b/tests/nvme/015
index 29cf954..47e1b04 100755
--- a/tests/nvme/015
+++ b/tests/nvme/015
@@ -10,7 +10,7 @@ DESCRIPTION="unit test for NVMe flush for file backed ns"
 QUICK=1
 
 requires() {
-	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
+	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
 }
 
 test() {
diff --git a/tests/nvme/018 b/tests/nvme/018
index b09c29c..e29fa92 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -11,7 +11,7 @@ DESCRIPTION="unit test NVMe-oF out of range access on a file backend"
 QUICK=1
 
 requires() {
-	_have_program nvme && _have_modules nvme-loop && _have_modules loop && \
+	_have_program nvme && _have_modules loop nvme-loop nvmet && \
 		_have_configfs
 }
 
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH blktests] add checking nvmet module in nvme 002,003,004,015,018 test
  2019-03-13  7:13 [PATCH blktests] add checking nvmet module in nvme 002,003,004,015,018 test Xiao Liang
@ 2019-03-13 17:47 ` Chaitanya Kulkarni
  2019-03-21 22:07 ` Omar Sandoval
  1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2019-03-13 17:47 UTC (permalink / raw)
  To: Xiao Liang, linux-block@vger.kernel.org, osandov@fb.com

Looks good.

Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 3/13/19 12:13 AM, Xiao Liang wrote:
> Signed-off-by: Xiao Liang <xiliang@redhat.com>
> ---
>   tests/nvme/002 | 2 +-
>   tests/nvme/003 | 2 +-
>   tests/nvme/004 | 2 +-
>   tests/nvme/015 | 2 +-
>   tests/nvme/018 | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/nvme/002 b/tests/nvme/002
> index 0132ac0..106a5a8 100755
> --- a/tests/nvme/002
> +++ b/tests/nvme/002
> @@ -10,7 +10,7 @@
>   DESCRIPTION="create many subsystems and test discovery"
>   
>   requires() {
> -	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
> +	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
>   }
>   
>   test() {
> diff --git a/tests/nvme/003 b/tests/nvme/003
> index f304071..c6b3d40 100755
> --- a/tests/nvme/003
> +++ b/tests/nvme/003
> @@ -11,7 +11,7 @@ DESCRIPTION="test if we're sending keep-alives to a discovery controller"
>   QUICK=1
>   
>   requires() {
> -	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
> +	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
>   }
>   
>   test() {
> diff --git a/tests/nvme/004 b/tests/nvme/004
> index 346f309..0506fa2 100755
> --- a/tests/nvme/004
> +++ b/tests/nvme/004
> @@ -12,7 +12,7 @@ DESCRIPTION="test nvme and nvmet UUID NS descriptors"
>   QUICK=1
>   
>   requires() {
> -	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
> +	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
>   }
>   
>   test() {
> diff --git a/tests/nvme/015 b/tests/nvme/015
> index 29cf954..47e1b04 100755
> --- a/tests/nvme/015
> +++ b/tests/nvme/015
> @@ -10,7 +10,7 @@ DESCRIPTION="unit test for NVMe flush for file backed ns"
>   QUICK=1
>   
>   requires() {
> -	_have_program nvme && _have_modules loop nvme-loop && _have_configfs
> +	_have_program nvme && _have_modules loop nvme-loop nvmet && _have_configfs
>   }
>   
>   test() {
> diff --git a/tests/nvme/018 b/tests/nvme/018
> index b09c29c..e29fa92 100755
> --- a/tests/nvme/018
> +++ b/tests/nvme/018
> @@ -11,7 +11,7 @@ DESCRIPTION="unit test NVMe-oF out of range access on a file backend"
>   QUICK=1
>   
>   requires() {
> -	_have_program nvme && _have_modules nvme-loop && _have_modules loop && \
> +	_have_program nvme && _have_modules loop nvme-loop nvmet && \
>   		_have_configfs
>   }
>   
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH blktests] add checking nvmet module in nvme 002,003,004,015,018 test
  2019-03-13  7:13 [PATCH blktests] add checking nvmet module in nvme 002,003,004,015,018 test Xiao Liang
  2019-03-13 17:47 ` Chaitanya Kulkarni
@ 2019-03-21 22:07 ` Omar Sandoval
  1 sibling, 0 replies; 3+ messages in thread
From: Omar Sandoval @ 2019-03-21 22:07 UTC (permalink / raw)
  To: Xiao Liang; +Cc: linux-block, osandov

On Wed, Mar 13, 2019 at 03:13:17PM +0800, Xiao Liang wrote:
> Signed-off-by: Xiao Liang <xiliang@redhat.com>
> ---
>  tests/nvme/002 | 2 +-
>  tests/nvme/003 | 2 +-
>  tests/nvme/004 | 2 +-
>  tests/nvme/015 | 2 +-
>  tests/nvme/018 | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)

Thanks, applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-21 22:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-13  7:13 [PATCH blktests] add checking nvmet module in nvme 002,003,004,015,018 test Xiao Liang
2019-03-13 17:47 ` Chaitanya Kulkarni
2019-03-21 22:07 ` Omar Sandoval

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox