From: Dennis Zhou <dennis@kernel.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: kernel-team@fb.com, linux-block@vger.kernel.org,
Dennis Zhou <dennis@kernel.org>
Subject: [PATCH] block: fix fio jobs for 027 and add cgroup support
Date: Fri, 29 Mar 2019 15:14:32 -0700 [thread overview]
Message-ID: <20190329221432.38726-1-dennis@kernel.org> (raw)
Previously, the test was broken as "$fio_jobs" was considered as a
string instead of additional parameters. This is fixed here.
Second, there was an issue with earlier kernels when request lists
existed such that request_queues were never being cleaned up because
non-root blkgs took a reference on the queue. However, blkgs were being
cleaned up after the last reference to the request_queue was put back.
This creates a blktest cgroup for the fio jobs to utilize and should be
useful for catching this scenario in the future.
Signed-off-by: Dennis Zhou <dennis@kernel.org>
---
tests/block/027 | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/block/027 b/tests/block/027
index b480016..36e88b4 100755
--- a/tests/block/027
+++ b/tests/block/027
@@ -26,6 +26,13 @@ scsi_debug_stress_remove() {
return
fi
+ _init_cgroup2
+
+ # setup cgroups
+ echo "+io" > "/sys/fs/cgroup/cgroup.subtree_control"
+ echo "+io" > "$CGROUP2_DIR/cgroup.subtree_control"
+ mkdir "$CGROUP2_DIR/fast"
+
# set higher aio limit
echo 524288 > /proc/sys/fs/aio-max-nr
@@ -45,13 +52,13 @@ scsi_debug_stress_remove() {
((cnt++))
done
- local num_jobs=4 runtime=21
+ local num_jobs=4 runtime=12
fio --rw=randread --size=128G --direct=1 --ioengine=libaio \
--iodepth=2048 --numjobs=$num_jobs --bs=4k \
--group_reporting=1 --group_reporting=1 --runtime=$runtime \
- --loops=10000 "$fio_jobs" > "$FULL" 2>&1 &
+ --loops=10000 --cgroup=blktests/fast $fio_jobs > "$FULL" 2>&1 &
- sleep 7
+ sleep 6
local device_path
for dev in "${SCSI_DEBUG_DEVICES[@]}"; do
# shutdown devices in progress
@@ -61,6 +68,10 @@ scsi_debug_stress_remove() {
wait
+ sleep 10
+
+ _exit_cgroup2
+
_exit_scsi_debug
}
--
2.17.1
next reply other threads:[~2019-03-29 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 22:14 Dennis Zhou [this message]
2019-04-04 18:02 ` [PATCH] block: fix fio jobs for 027 and add cgroup support Omar Sandoval
2019-04-04 21:06 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329221432.38726-1-dennis@kernel.org \
--to=dennis@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox