Re: [PATCH blktests] block/020: dynamically change iodepth if test aio-nr lager than aio-max-nr

Omar Sandoval
2019-04-04T18:10:59Z

On Mon, Apr 01, 2019 at 11:38:00AM +0800, Xiao Liang wrote:
> When system has large count of cpus(eg. 96), the test failed as aio-nr over
> aio-max-nr limitation.
>
> This patch continues to use 1024 as default iodepth, but change it if
> iodepth*$(nproc) > aio-max-nr.
>
> Signed-off-by: Xiao Liang <xiliang@redhat.com>
> ---
> tests/block/020 | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tests/block/020 b/tests/block/020
> index 39dde66..f03c131 100755
> --- a/tests/block/020
> +++ b/tests/block/020
> @@ -29,10 +29,16 @@ test() {
> # shellcheck disable=SC2207
> scheds=($(sed 's/[][]//g' /sys/block/nullb0/queue/scheduler))
>
> + aio_max_nr=$(cat /proc/sys/fs/aio-max-nr)
> + max_iodepth=$(($aio_max_nr/$(nproc)))
> + iodepth=1024
> + if (( $iodepth > $max_iodepth )); then
> + iodepth=$max_iodepth
> + fi

This has a few shellcheck errors:

tests/block/020:33:17: note: $/${} is unnecessary on arithmetic variables. [SC2004]
tests/block/020:35:8: note: $/${} is unnecessary on arithmetic variables. [SC2004]
tests/block/020:35:19: note: $/${} is unnecessary on arithmetic variables. [SC2004]

Can you please address those and resend?

Thanks!