* [PATCH] block: remove unused variable 'def'
@ 2019-04-07 15:27 Hisao Tanabe
2019-04-08 6:31 ` Christoph Hellwig
2019-04-08 14:13 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Hisao Tanabe @ 2019-04-07 15:27 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Hisao Tanabe
The 'def' local variable became unused after commit f382fb0bcef4 ("block: remove
legacy IO schedulers"), let's remove it.
Signed-off-by: Hisao Tanabe <xtanabe@gmail.com>
---
block/elevator.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block/elevator.c b/block/elevator.c
index d6d835a08de6..2e5399d9f40f 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -509,8 +509,6 @@ void elv_unregister_queue(struct request_queue *q)
int elv_register(struct elevator_type *e)
{
- char *def = "";
-
/* create icq_cache if requested */
if (e->icq_size) {
if (WARN_ON(e->icq_size < sizeof(struct io_cq)) ||
@@ -535,8 +533,8 @@ int elv_register(struct elevator_type *e)
list_add_tail(&e->list, &elv_list);
spin_unlock(&elv_list_lock);
- printk(KERN_INFO "io scheduler %s registered%s\n", e->elevator_name,
- def);
+ printk(KERN_INFO "io scheduler %s registered\n", e->elevator_name);
+
return 0;
}
EXPORT_SYMBOL_GPL(elv_register);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] block: remove unused variable 'def'
2019-04-07 15:27 [PATCH] block: remove unused variable 'def' Hisao Tanabe
@ 2019-04-08 6:31 ` Christoph Hellwig
2019-04-08 14:13 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-04-08 6:31 UTC (permalink / raw)
To: Hisao Tanabe; +Cc: Jens Axboe, linux-block
On Mon, Apr 08, 2019 at 12:27:42AM +0900, Hisao Tanabe wrote:
> The 'def' local variable became unused after commit f382fb0bcef4 ("block: remove
> legacy IO schedulers"), let's remove it.
>
> Signed-off-by: Hisao Tanabe <xtanabe@gmail.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] block: remove unused variable 'def'
2019-04-07 15:27 [PATCH] block: remove unused variable 'def' Hisao Tanabe
2019-04-08 6:31 ` Christoph Hellwig
@ 2019-04-08 14:13 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-04-08 14:13 UTC (permalink / raw)
To: Hisao Tanabe; +Cc: linux-block
On 4/7/19 9:27 AM, Hisao Tanabe wrote:
> The 'def' local variable became unused after commit f382fb0bcef4 ("block: remove
> legacy IO schedulers"), let's remove it.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-08 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-07 15:27 [PATCH] block: remove unused variable 'def' Hisao Tanabe
2019-04-08 6:31 ` Christoph Hellwig
2019-04-08 14:13 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).