From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5618BC282CE for ; Wed, 24 Apr 2019 14:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D25021902 for ; Wed, 24 Apr 2019 14:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556116575; bh=c2SzM4ouugjjRHit0TX3VSCrw2FWnHJtGKYLg3TbwQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HJIXMFYmAm2NRlsZkThVK3zw0dO4V27ZzNuWwEKMCs0a4OglSbwYkJik/yygBJFQL R1EtRe+PreDLGhRp8z/R3AOs+00ty3WU1Kv1fa90ebcK4MtCwQJUzPYh9eXVVdCWZ5 7AFKMa47Ifqr0t1/lk4Hc5fwkfk4UuQMMZ8woBwE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731063AbfDXOgO (ORCPT ); Wed, 24 Apr 2019 10:36:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:39926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731034AbfDXOgM (ORCPT ); Wed, 24 Apr 2019 10:36:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F060218FD; Wed, 24 Apr 2019 14:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556116572; bh=c2SzM4ouugjjRHit0TX3VSCrw2FWnHJtGKYLg3TbwQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mlpPTil+Hh/iGdCJIRZUHVePHSAf83laWbhQiUu7qldnhMTelnIrr9ZVk6wVBXqm1 yx+dKWywPsdrWO/fG9pp+qhjjyaNvVZavjUW3nSWJy9ZYcJ8KerHh0wAL/RatPqKca I++UMXApNLL+nH48I6ykVEEzsdx1VtQ0V7DhRNfw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: John Pittman , Jens Axboe , Sasha Levin , linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 5.0 57/66] null_blk: prevent crash from bad home_node value Date: Wed, 24 Apr 2019 10:33:31 -0400 Message-Id: <20190424143341.27665-57-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190424143341.27665-1-sashal@kernel.org> References: <20190424143341.27665-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: John Pittman [ Upstream commit 7ff684a683d777c4956fce93e60accbab2bd7696 ] At module load, if the selected home_node value is greater than the available numa nodes, the system will crash in __alloc_pages_nodemask() due to a bad paging request. Prevent this user error crash by detecting the bad value, logging an error, and setting g_home_node back to the default of NUMA_NO_NODE. Signed-off-by: John Pittman Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin (Microsoft) --- drivers/block/null_blk_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index 62c9654b9ce8..fd7a9be54595 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -1749,6 +1749,11 @@ static int __init null_init(void) return -EINVAL; } + if (g_home_node != NUMA_NO_NODE && g_home_node >= nr_online_nodes) { + pr_err("null_blk: invalid home_node value\n"); + g_home_node = NUMA_NO_NODE; + } + if (g_queue_mode == NULL_Q_RQ) { pr_err("null_blk: legacy IO path no longer available\n"); return -EINVAL; -- 2.19.1