From: Christoph Hellwig <hch@infradead.org>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [RFC PATCH 02/18] blktrace: add more definitions for BLK_TC_ACT
Date: Wed, 1 May 2019 05:31:04 -0700 [thread overview]
Message-ID: <20190501123104.GA17987@infradead.org> (raw)
In-Reply-To: <20190501042831.5313-3-chaitanya.kulkarni@wdc.com>
On Tue, Apr 30, 2019 at 09:28:15PM -0700, Chaitanya Kulkarni wrote:
> @@ -104,7 +120,12 @@ struct blk_io_trace {
> __u64 time; /* in nanoseconds */
> __u64 sector; /* disk offset */
> __u32 bytes; /* transfer length */
> +
> +#ifdef CONFIG_BLKTRACE_EXT
> + __u64 action; /* what happened */
> +#else
> __u32 action; /* what happened */
> +#endif /* CONFIG_BLKTRACE_EXT */
You can't use CONFIG_ symbols in UAPI headers, as userspace
applications won't set it. You also can't ever change the layout of an
existing structure in UAPI headers in not backward compatible way.
next prev parent reply other threads:[~2019-05-01 12:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 4:28 [RFC PATCH 00/18] blktrace: add blktrace extension support Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 01/18] blktrace: increase the size of action mask Chaitanya Kulkarni
2019-05-01 15:48 ` Bart Van Assche
2019-05-02 3:43 ` Chaitanya Kulkarni
2019-05-02 15:12 ` Bart Van Assche
2019-05-01 4:28 ` [RFC PATCH 02/18] blktrace: add more definitions for BLK_TC_ACT Chaitanya Kulkarni
2019-05-01 12:31 ` Christoph Hellwig [this message]
2019-05-01 12:56 ` Jeff Moyer
2019-05-02 3:48 ` Chaitanya Kulkarni
2019-05-02 3:49 ` Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 03/18] blktrace: update trace to track more actions Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 04/18] kernel/trace: add KConfig to enable blktrace_ext Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 05/18] blktrace: add iopriority mask Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 06/18] " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 07/18] blktrace: allow user to track iopriority Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 08/18] blktrace: add sysfs ioprio mask Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 09/18] blktrace: add debug support for extension Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 10/18] block: set ioprio for write-zeroes, discard etc Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 11/18] block: set ioprio for zone-reset Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 12/18] block: set ioprio for flush bio Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 13/18] drivers: set bio iopriority field Chaitanya Kulkarni
2019-05-01 6:23 ` Javier González
2019-05-01 4:28 ` [RFC PATCH 14/18] fs: " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 15/18] power/swap: " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 16/18] mm: " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 17/18] null_blk: add write-zeroes flag to nullb_device Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 18/18] null_blk: add module param discard/write-zeroes Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501123104.GA17987@infradead.org \
--to=hch@infradead.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).