From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7D2C04AB1 for ; Mon, 13 May 2019 07:03:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8936220B7C for ; Mon, 13 May 2019 07:03:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="O+pqQVhZ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="u0ZrxH9q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbfEMHDq (ORCPT ); Mon, 13 May 2019 03:03:46 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:46871 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfEMHDp (ORCPT ); Mon, 13 May 2019 03:03:45 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4120221540; Mon, 13 May 2019 03:03:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 13 May 2019 03:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=EUprfd4oTQRMt24J3KzcRvPKyEC 6+T0VwqaT8sTkVCE=; b=O+pqQVhZvmV60GYSMSAkdPunsYnKVKX9Ef6sOa/m7bH FFjRERT88Z92kd/CJrXq8YU/aCGRL21/I9HEr2GkxCk0PEc4Ny9HxEyvAuJZdZDq 68lKzzGRnJ5YeR3QvBLtWW0zmfESSVIVSgTtziPOAgoeuhlO5prPkrTVNmjI5FwL 2ahAmU4T5HiRg+LFlZYRBCu6Cq5BHsfdhIciVjMpCB1b02DKxzBzv4v9fXs0xc12 7lsqCgDQjLIYZNaU2gZb9bJ65T7P1SG8ySOB4ZstvBWSMa+vxPc7uuWVqsd+D6uY 9LTr3nurXg/+zqGxvCOevMb/LonFmNFrzcnL12NhWdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EUprfd 4oTQRMt24J3KzcRvPKyEC6+T0VwqaT8sTkVCE=; b=u0ZrxH9qkt4z4EjTNRDODL Nw2XJzCfLQi0IbMnaeIfXHSd3+q2eXRR8fjSxBNCphRPb+8Jds4FBA9wOg4WQlvx 8fo530OWzq4Ir3lIh0CULIadj2ukGJ7Rka/aBFe4Uk/ovIBZ7BVmEVJ1zfmYDsiL DWYh9i+r38cQQlndCZcYIwD0h4DQK7idZXVSRGMMmyDclKfZU7ruQEsAqEC+PJAp I/wqeDo5OlnuN5LUMTqpNk2zWy3XmTQY65xf51DqpGQDMt6gKNWN2tlicffqH9oE RAv8q+Rj2RXbEVr3pKYhNccroYFZBtlrRNw/wRkOnLaaDUToOcPz+JsL9z0qxZLQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleefgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekledrud dtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id D03EF80060; Mon, 13 May 2019 03:03:40 -0400 (EDT) Date: Mon, 13 May 2019 09:03:37 +0200 From: Greg KH To: Sasha Levin Cc: Eric Wheeler , Paolo Valente , Jens Axboe , "open list:BFQ I/O SCHEDULER" , open list , Eric Wheeler , stable@vger.kernel.org Subject: Re: [PATCH] bfq: backport: update internal depth state when queue depth changes Message-ID: <20190513070337.GB26553@kroah.com> References: <1557510992-18506-1-git-send-email-stable@lists.ewheeler.net> <20190510201855.GB14410@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190510201855.GB14410@sasha-vm> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, May 10, 2019 at 04:18:55PM -0400, Sasha Levin wrote: > On Fri, May 10, 2019 at 10:56:32AM -0700, Eric Wheeler wrote: > > From: Jens Axboe > > > > commit 77f1e0a52d26242b6c2dba019f6ebebfb9ff701e upstream > > > > A previous commit moved the shallow depth and BFQ depth map calculations > > to be done at init time, moving it outside of the hotter IO path. This > > potentially causes hangs if the users changes the depth of the scheduler > > map, by writing to the 'nr_requests' sysfs file for that device. > > > > Add a blk-mq-sched hook that allows blk-mq to inform the scheduler if > > the depth changes, so that the scheduler can update its internal state. > > > > Signed-off-by: Eric Wheeler > > Tested-by: Kai Krakow > > Reported-by: Paolo Valente > > Fixes: f0635b8a416e ("bfq: calculate shallow depths at init time") > > Signed-off-by: Jens Axboe > > Cc: stable@vger.kernel.org > > I wasn't clear on what was backported here, so I've queued the upstream > version on 4.19 and 4.14, it doesn't seem to be relevant to older > branches. I only see this added to the 5.0 and 4.19 queues, did you forget to push the 4.14 update? thanks, greg k-h