From: Kees Cook <keescook@chromium.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/8] block: Fix throtl_pending_timer_fn() kernel-doc header
Date: Thu, 30 May 2019 19:08:04 -0700 [thread overview]
Message-ID: <201905301908.D4CD6A81F7@keescook> (raw)
In-Reply-To: <20190531000053.64053-4-bvanassche@acm.org>
On Thu, May 30, 2019 at 05:00:48PM -0700, Bart Van Assche wrote:
> Commit e99e88a9d2b0 renamed a function argument without updating the
> corresponding kernel-doc header. Update the kernel-doc header.
>
> Cc: Kees Cook <keescook@chromium.org>
> Fixes: e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") # v4.15.
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> block/blk-throttle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 1b97a73d2fb1..9ea7c0ecad10 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -1220,7 +1220,7 @@ static bool throtl_can_upgrade(struct throtl_data *td,
> struct throtl_grp *this_tg);
> /**
> * throtl_pending_timer_fn - timer function for service_queue->pending_timer
> - * @arg: the throtl_service_queue being serviced
> + * @t: the pending_timer member of the throtl_service_queue being serviced
> *
> * This timer is armed when a child throtl_grp with active bio's become
> * pending and queued on the service_queue's pending_tree and expires when
> --
> 2.22.0.rc1
>
--
Kees Cook
next prev parent reply other threads:[~2019-05-31 2:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 0:00 [PATCH 0/8] Improve block layer function documentation Bart Van Assche
2019-05-31 0:00 ` [PATCH 1/8] block/partitions/ldm: Convert a kernel-doc header into a non-kernel-doc header Bart Van Assche
2019-05-31 2:00 ` Chaitanya Kulkarni
2019-05-31 0:00 ` [PATCH 2/8] block: Convert blk_invalidate_devt() " Bart Van Assche
2019-05-31 2:00 ` Chaitanya Kulkarni
2019-05-31 0:00 ` [PATCH 3/8] block: Fix throtl_pending_timer_fn() kernel-doc header Bart Van Assche
2019-05-31 2:01 ` Chaitanya Kulkarni
2019-05-31 2:08 ` Kees Cook [this message]
2019-05-31 0:00 ` [PATCH 4/8] block: Fix blk_mq_*_map_queues() kernel-doc headers Bart Van Assche
2019-05-31 2:01 ` Chaitanya Kulkarni
2019-05-31 0:00 ` [PATCH 5/8] block: Fix rq_qos_wait() kernel-doc header Bart Van Assche
2019-05-31 2:02 ` Chaitanya Kulkarni
2019-05-31 0:00 ` [PATCH 6/8] block: Fix bsg_setup_queue() " Bart Van Assche
2019-05-31 2:02 ` Chaitanya Kulkarni
2019-05-31 0:00 ` [PATCH 7/8] blk-mq: Fix spelling in a source code comment Bart Van Assche
2019-05-31 2:03 ` Chaitanya Kulkarni
2019-05-31 0:00 ` [PATCH 8/8] blk-mq: Document the blk_mq_hw_queue_to_node() arguments Bart Van Assche
2019-05-31 2:04 ` Chaitanya Kulkarni
2019-05-31 16:58 ` [PATCH 0/8] Improve block layer function documentation Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905301908.D4CD6A81F7@keescook \
--to=keescook@chromium.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox