From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
David Gibson <david@gibson.dropbear.id.au>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: alternative take on the same page merging leak fix
Date: Wed, 12 Jun 2019 09:45:27 +0200 [thread overview]
Message-ID: <20190612074527.GA20491@lst.de> (raw)
In-Reply-To: <20190612010922.GA17522@ming.t460p>
On Wed, Jun 12, 2019 at 09:09:23AM +0800, Ming Lei wrote:
> We have to backport the fixes to -stable tree, and downstream need to
> ship the fix too.
>
> The issue is quite serious because the leak is in IO path and the whole
> system ram can be used up easily on some workloads. So I think the fix
> should be for 5.2, however, regression risk might be increased by
> pulling cleanup & re-factor in now.
>
> I really appreciate you may cook a fix-only patch for this issue.
> Especially the change in add pc page code isn't necessary for fixing
> the issue.
Patches 3 and 4 have no dependencies on 1 and 2, and should have
arguably been ordered first in the series.
next prev parent reply other threads:[~2019-06-12 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 15:10 alternative take on the same page merging leak fix Christoph Hellwig
2019-06-11 15:10 ` [PATCH 1/5] block: fix gap checking in __bio_add_pc_page Christoph Hellwig
2019-06-11 15:10 ` [PATCH 2/5] block: factor out a bio_try_merge_pc_page helper Christoph Hellwig
2019-06-11 15:10 ` [PATCH 3/5] block: return from __bio_try_merge_page if merging occured in the same page Christoph Hellwig
2019-06-12 10:14 ` Ming Lei
2019-06-11 15:10 ` [PATCH 4/5] block: fix page leak when merging to " Christoph Hellwig
2019-06-12 10:18 ` Ming Lei
2019-06-11 15:10 ` [PATCH 5/5] block: use __bio_try_merge_page in __bio_try_merge_pc_page Christoph Hellwig
2019-06-12 1:09 ` alternative take on the same page merging leak fix Ming Lei
2019-06-12 7:45 ` Christoph Hellwig [this message]
2019-06-12 10:11 ` Ming Lei
2019-06-13 9:02 ` Jens Axboe
2019-06-13 9:02 ` Christoph Hellwig
2019-06-13 9:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612074527.GA20491@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=david@gibson.dropbear.id.au \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).