From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
David Gibson <david@gibson.dropbear.id.au>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: alternative take on the same page merging leak fix v2
Date: Fri, 14 Jun 2019 07:45:14 +0200 [thread overview]
Message-ID: <20190614054514.GB6722@lst.de> (raw)
In-Reply-To: <20190614011946.GB14436@ming.t460p>
On Fri, Jun 14, 2019 at 09:19:47AM +0800, Ming Lei wrote:
> On Thu, Jun 13, 2019 at 04:04:03AM -0600, Jens Axboe wrote:
> > On 6/13/19 3:55 AM, Christoph Hellwig wrote:
> > > Hi Jens, hi Ming,
> > >
> > > this is the tested and split version of what I think is the better
> > > fix for the get_user_pages page leak, as it leaves the intelligence
> > > in the callers instead of in bio_try_to_merge_page.
> > >
> > > Changes since v1:
> > > - drop patches not required for 5.2
> > > - added Reviewed-by tags
> >
> > Applied for 5.2, thanks.
>
> Hi Jens & Christoph,
>
> Looks the following change is missed in patch 1, otherwise kernel oops
> is triggered during kernel booting:
Ok, true, sorry.
Reviewed-by: Christoph Hellwig <hch@lst.de>
and you probably want to cook it up for Jens with a proper changelog.
next prev parent reply other threads:[~2019-06-14 5:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 9:55 alternative take on the same page merging leak fix v2 Christoph Hellwig
2019-06-13 9:55 ` [PATCH 1/2] block: return from __bio_try_merge_page if merging occured in the same page Christoph Hellwig
2019-06-13 9:55 ` [PATCH 2/2] block: fix page leak when merging to " Christoph Hellwig
2019-06-13 10:04 ` alternative take on the same page merging leak fix v2 Jens Axboe
2019-06-14 1:19 ` Ming Lei
2019-06-14 5:45 ` Christoph Hellwig [this message]
2019-06-14 6:52 ` Ming Lei
2019-06-14 6:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614054514.GB6722@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=david@gibson.dropbear.id.au \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox